Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java

Issue 8786002: Check that interface constructors and default class constructors are compatible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Check that types of constructors parameters are identical Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java b/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
index 800cd84ffd8482ac03ae74b6d71af0bd5260fd3b..4371e256255e0102aa05f0a4958ae60e292f9ba1 100644
--- a/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
+++ b/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
@@ -411,19 +411,6 @@ public class ResolverTest extends ResolverTestCase {
ResolverErrorCode.FACTORY_CONSTRUCTOR_TYPE_ARGS_DO_NOT_MATCH);
}
- public void disabledBadFactorySignature() {
- // Number of positional arguments must match
- resolveAndTest(Joiner.on("\n").join(
- "class Object {}",
- "interface A factory B {",
- " A();",
- "}",
- "class B {",
- " A(foo) {}",
- "}"),
- ResolverErrorCode.FACTORY_CONSTRUCTOR_SIGNATURE_DOES_NOT_MATCH);
- }
-
public void disabledNonConstructorMethodTypeArgs() {
// Type arguments match
resolveAndTest(Joiner.on("\n").join(

Powered by Google App Engine
This is Rietveld 408576698