Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

Issue 8786002: Check that interface constructors and default class constructors are compatible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Check that types of constructors parameters are identical Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
index 47cf5bf0d3abfbf4b24fa75923f1ab1260cbca73..e5a0c47c9eb6638d3f7ff1ea5589e6e7b74ba605 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
@@ -322,19 +322,6 @@ public class TypeAnalyzerTest extends TypeAnalyzerTestCase {
TypeErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
}
- public void testFactory() {
- analyzeClasses(loadSource(
- "interface Foo factory Bar {",
- " Foo(argument);",
zundel 2011/12/05 21:26:45 we probably want to add the 'String' type here so
- "}",
- "interface Baz {}",
- "class Bar implements Foo, Baz {",
- " Bar(String argument) {}",
- "}"));
-
- analyzeFail("Baz x = new Foo('');", TypeErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
zundel 2011/12/05 21:26:45 why did you remove this test? this statement shou
scheglov 2011/12/06 14:20:39 Done.
- }
-
public void testFieldAccess() {
ClassElement element = loadFile("class_with_supertypes.dart").get("ClassWithSupertypes");
assertNotNull("unable to locate ClassWithSupertypes", element);

Powered by Google App Engine
This is Rietveld 408576698