chrome/browser/sync/engine/process_updates_command.cc - Issue 8785015: Revert 112815 - [Sync] Make syncer commands avoid posting tasks on threads with no work to do

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/process_updates_command.cc

Issue 8785015: Revert 112815 - [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/engine/process_updates_command.h ('k') | chrome/browser/sync/engine/process_updates_command_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/engine/process_updates_command.cc

===================================================================

--- chrome/browser/sync/engine/process_updates_command.cc (revision 112854)

+++ chrome/browser/sync/engine/process_updates_command.cc (working copy)

@@ -22,20 +22,10 @@

using sessions::SyncSession;

using sessions::StatusController;

-using sessions::UpdateProgress;

ProcessUpdatesCommand::ProcessUpdatesCommand() {}

ProcessUpdatesCommand::~ProcessUpdatesCommand() {}

-std::set<ModelSafeGroup> ProcessUpdatesCommand::GetGroupsToChange(

- const sessions::SyncSession& session) const {

- // TODO(akalin): Figure out why using

- // GetEnabledGroupsWithVerifiedUpdates() regresses the perf tests

- // for delete_typed_urls, add_autofill_profiles, and

- // delete_autofill_profiles.

- return session.GetEnabledGroups();

bool ProcessUpdatesCommand::ModelNeutralExecuteImpl(SyncSession* session) {

const GetUpdatesResponse& updates =

session->status_controller().updates_response().get_updates();