Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: chrome/browser/sync/engine/process_updates_command.cc

Issue 8785015: Revert 112815 - [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/engine/process_updates_command.h" 5 #include "chrome/browser/sync/engine/process_updates_command.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/location.h" 10 #include "base/location.h"
11 #include "chrome/browser/sync/engine/syncer.h" 11 #include "chrome/browser/sync/engine/syncer.h"
12 #include "chrome/browser/sync/engine/syncer_proto_util.h" 12 #include "chrome/browser/sync/engine/syncer_proto_util.h"
13 #include "chrome/browser/sync/engine/syncer_util.h" 13 #include "chrome/browser/sync/engine/syncer_util.h"
14 #include "chrome/browser/sync/engine/syncproto.h" 14 #include "chrome/browser/sync/engine/syncproto.h"
15 #include "chrome/browser/sync/sessions/sync_session.h" 15 #include "chrome/browser/sync/sessions/sync_session.h"
16 #include "chrome/browser/sync/syncable/directory_manager.h" 16 #include "chrome/browser/sync/syncable/directory_manager.h"
17 #include "chrome/browser/sync/syncable/syncable.h" 17 #include "chrome/browser/sync/syncable/syncable.h"
18 18
19 using std::vector; 19 using std::vector;
20 20
21 namespace browser_sync { 21 namespace browser_sync {
22 22
23 using sessions::SyncSession; 23 using sessions::SyncSession;
24 using sessions::StatusController; 24 using sessions::StatusController;
25 using sessions::UpdateProgress;
26 25
27 ProcessUpdatesCommand::ProcessUpdatesCommand() {} 26 ProcessUpdatesCommand::ProcessUpdatesCommand() {}
28 ProcessUpdatesCommand::~ProcessUpdatesCommand() {} 27 ProcessUpdatesCommand::~ProcessUpdatesCommand() {}
29 28
30 std::set<ModelSafeGroup> ProcessUpdatesCommand::GetGroupsToChange(
31 const sessions::SyncSession& session) const {
32 // TODO(akalin): Figure out why using
33 // GetEnabledGroupsWithVerifiedUpdates() regresses the perf tests
34 // for delete_typed_urls, add_autofill_profiles, and
35 // delete_autofill_profiles.
36 return session.GetEnabledGroups();
37 }
38
39 bool ProcessUpdatesCommand::ModelNeutralExecuteImpl(SyncSession* session) { 29 bool ProcessUpdatesCommand::ModelNeutralExecuteImpl(SyncSession* session) {
40 const GetUpdatesResponse& updates = 30 const GetUpdatesResponse& updates =
41 session->status_controller().updates_response().get_updates(); 31 session->status_controller().updates_response().get_updates();
42 const int update_count = updates.entries_size(); 32 const int update_count = updates.entries_size();
43 33
44 // Don't bother processing updates if there were none. 34 // Don't bother processing updates if there were none.
45 return update_count != 0; 35 return update_count != 0;
46 } 36 }
47 37
48 void ProcessUpdatesCommand::ModelChangingExecuteImpl(SyncSession* session) { 38 void ProcessUpdatesCommand::ModelChangingExecuteImpl(SyncSession* session) {
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // Force application of this update, no matter what. 146 // Force application of this update, no matter what.
157 target_entry.Put(syncable::IS_UNAPPLIED_UPDATE, true); 147 target_entry.Put(syncable::IS_UNAPPLIED_UPDATE, true);
158 } 148 }
159 149
160 SyncerUtil::UpdateServerFieldsFromUpdate(&target_entry, update, name); 150 SyncerUtil::UpdateServerFieldsFromUpdate(&target_entry, update, name);
161 151
162 return SUCCESS_PROCESSED; 152 return SUCCESS_PROCESSED;
163 } 153 }
164 154
165 } // namespace browser_sync 155 } // namespace browser_sync
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/process_updates_command.h ('k') | chrome/browser/sync/engine/process_updates_command_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698