Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6822)

Unified Diff: chrome/browser/safe_browsing/malware_details_unittest.cc

Issue 8785004: Change NavigationController::LoadURL to take a Referrer class instead of a GURL as referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/malware_details_unittest.cc
diff --git a/chrome/browser/safe_browsing/malware_details_unittest.cc b/chrome/browser/safe_browsing/malware_details_unittest.cc
index 073198013e7161d651e88385e6a0380805a7811c..67fdb68c00dfd0bc97b71ba0273b15b944b474a7 100644
--- a/chrome/browser/safe_browsing/malware_details_unittest.cc
+++ b/chrome/browser/safe_browsing/malware_details_unittest.cc
@@ -313,7 +313,7 @@ class MalwareDetailsTest : public ChromeRenderViewHostTestHarness {
// Tests creating a simple malware report.
TEST_F(MalwareDetailsTest, MalwareSubResource) {
// Start a load.
- controller().LoadURL(GURL(kLandingURL), GURL(),
+ controller().LoadURL(GURL(kLandingURL), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;
@@ -345,7 +345,7 @@ TEST_F(MalwareDetailsTest, MalwareSubResource) {
// Tests creating a simple malware report where the subresource has a
// different original_url.
TEST_F(MalwareDetailsTest, MalwareSubResourceWithOriginalUrl) {
- controller().LoadURL(GURL(kLandingURL), GURL(),
+ controller().LoadURL(GURL(kLandingURL), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;
@@ -385,7 +385,7 @@ TEST_F(MalwareDetailsTest, MalwareSubResourceWithOriginalUrl) {
// Tests creating a malware report with data from the renderer.
TEST_F(MalwareDetailsTest, MalwareDOMDetails) {
- controller().LoadURL(GURL(kLandingURL), GURL(),
+ controller().LoadURL(GURL(kLandingURL), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;
@@ -442,8 +442,8 @@ TEST_F(MalwareDetailsTest, MalwareDOMDetails) {
// Verify that https:// urls are dropped.
TEST_F(MalwareDetailsTest, NotPublicUrl) {
- controller().LoadURL(GURL(kHttpsURL), GURL(), content::PAGE_TRANSITION_TYPED,
- std::string());
+ controller().LoadURL(GURL(kHttpsURL), content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;
InitResource(&resource, true, GURL(kMalwareURL));
scoped_refptr<MalwareDetailsWrap> report = new MalwareDetailsWrap(
@@ -466,7 +466,7 @@ TEST_F(MalwareDetailsTest, NotPublicUrl) {
// Tests creating a malware report where there are redirect urls to an unsafe
// resource url
TEST_F(MalwareDetailsTest, MalwareWithRedirectUrl) {
- controller().LoadURL(GURL(kLandingURL), GURL(),
+ controller().LoadURL(GURL(kLandingURL), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;
@@ -518,7 +518,7 @@ TEST_F(MalwareDetailsTest, MalwareWithRedirectUrl) {
// Tests the interaction with the HTTP cache.
TEST_F(MalwareDetailsTest, HTTPCache) {
- controller().LoadURL(GURL(kLandingURL), GURL(),
+ controller().LoadURL(GURL(kLandingURL), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;
@@ -591,7 +591,7 @@ TEST_F(MalwareDetailsTest, HTTPCache) {
// Tests the interaction with the HTTP cache (where the cache is empty).
TEST_F(MalwareDetailsTest, HTTPCacheNoEntries) {
- controller().LoadURL(GURL(kLandingURL), GURL(),
+ controller().LoadURL(GURL(kLandingURL), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;
@@ -645,7 +645,7 @@ TEST_F(MalwareDetailsTest, HistoryServiceUrls) {
// Wait for history service operation finished.
profile()->BlockUntilHistoryProcessesPendingRequests();
- controller().LoadURL(GURL(kLandingURL), GURL(),
+ controller().LoadURL(GURL(kLandingURL), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
SafeBrowsingService::UnsafeResource resource;

Powered by Google App Engine
This is Rietveld 408576698