Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2503)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 8785004: Change NavigationController::LoadURL to take a Referrer class instead of a GURL as referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
index c398aa18ebe4ed09801ca294382380e97a8032f8..10be2d4db6f12c0c692807ca4fdf7b1ec3a72262 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
@@ -189,8 +189,8 @@ TEST_F(SafeBrowsingBlockingPageTest, MalwarePageDontProceed) {
profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
// Start a load.
- controller().LoadURL(GURL(kBadURL), GURL(), content::PAGE_TRANSITION_TYPED,
- std::string());
+ controller().LoadURL(GURL(kBadURL), content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
// Simulate the load causing a safe browsing interstitial to be shown.
@@ -222,8 +222,8 @@ TEST_F(SafeBrowsingBlockingPageTest, MalwarePageProceed) {
profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
// Start a load.
- controller().LoadURL(GURL(kBadURL), GURL(), content::PAGE_TRANSITION_TYPED,
- std::string());
+ controller().LoadURL(GURL(kBadURL), content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
// Simulate the load causing a safe browsing interstitial to be shown.
ShowInterstitial(false, kBadURL);
@@ -467,8 +467,8 @@ TEST_F(SafeBrowsingBlockingPageTest, NavigatingBackAndForth) {
Navigate(kGoodURL, 1);
// Now navigate to a bad page triggerring an interstitial.
- controller().LoadURL(GURL(kBadURL), GURL(), content::PAGE_TRANSITION_TYPED,
- std::string());
+ controller().LoadURL(GURL(kBadURL), content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
ShowInterstitial(false, kBadURL);
SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
ASSERT_TRUE(sb_interstitial);
@@ -511,8 +511,8 @@ TEST_F(SafeBrowsingBlockingPageTest, ProceedThenDontProceed) {
profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
// Start a load.
- controller().LoadURL(GURL(kBadURL), GURL(), content::PAGE_TRANSITION_TYPED,
- std::string());
+ controller().LoadURL(GURL(kBadURL), content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
// Simulate the load causing a safe browsing interstitial to be shown.
ShowInterstitial(false, kBadURL);
@@ -545,8 +545,8 @@ TEST_F(SafeBrowsingBlockingPageTest, MalwareReportsDisabled) {
profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, false);
// Start a load.
- controller().LoadURL(GURL(kBadURL), GURL(), content::PAGE_TRANSITION_TYPED,
- std::string());
+ controller().LoadURL(GURL(kBadURL), content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
// Simulate the load causing a safe browsing interstitial to be shown.
ShowInterstitial(false, kBadURL);
@@ -577,8 +577,8 @@ TEST_F(SafeBrowsingBlockingPageTest, MalwareReports) {
profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, false);
// Start a load.
- controller().LoadURL(GURL(kBadURL), GURL(), content::PAGE_TRANSITION_TYPED,
- std::string());
+ controller().LoadURL(GURL(kBadURL), content::Referrer(),
+ content::PAGE_TRANSITION_TYPED, std::string());
// Simulate the load causing a safe browsing interstitial to be shown.
ShowInterstitial(false, kBadURL);
« no previous file with comments | « chrome/browser/safe_browsing/malware_details_unittest.cc ('k') | chrome/browser/sidebar/sidebar_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698