Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 8785004: Change NavigationController::LoadURL to take a Referrer class instead of a GURL as referrer (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, jstritar+watch_chromium.org, cbentzel+watch_chromium.org, creis+watch_chromium.org, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, ajwong+watch_chromium.org, mmenke, Paweł Hajdan Jr., Avi (use Gerrit), darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change NavigationController::LoadURL to take a Referrer class instead of a GURL as referrer BUG=105028 TEST=no functional change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112968

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : rebase #

Patch Set 5 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -187 lines) Patch
M chrome/browser/automation/automation_provider_win.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bug_report_util.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page_unittest.cc View 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 2 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 2 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
chrome/browser/tab_contents/web_contents_unittest.cc View 2 38 chunks +49 lines, -40 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
chrome/browser/ui/gtk/html_dialog_gtk.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_gtk.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_views.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dom_view.cc View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 2 6 chunks +16 lines, -8 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 2 2 chunks +3 lines, -3 lines 0 comments Download
content/browser/renderer_host/render_view_host_unittest.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_controller.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_unittest.cc View 2 35 chunks +60 lines, -52 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 2 6 chunks +9 lines, -6 lines 0 comments Download
M content/browser/tab_contents/test_tab_contents.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell.cc View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
please review I change the type of the referrer parameter, and update all call sites ...
9 years ago (2011-12-02 22:22:48 UTC) #1
jam
Avi: please review, thanks
9 years ago (2011-12-04 23:02:34 UTC) #2
Avi (use Gerrit)
Exiting early; same basic question as in http://codereview.chromium.org/8784006/: I thought we wrapped all WebKit types ...
9 years ago (2011-12-05 02:34:56 UTC) #3
Avi (use Gerrit)
9 years ago (2011-12-05 03:29:59 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698