Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, jstritar+watch_chromium.org, ncarter (slow), creis+watch_chromium.org, akalin, Raghu Simha, ajwong+watch_chromium.org, jam, Erik does not do reviews, brettw-cc_chromium.org, kkania, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, robertshield, tim (not reviewing), Paweł Hajdan Jr., Avi (use Gerrit), darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Replace the GURL referrer field of OpenURLParams with a content::Referrer BUG=105028 TEST=none (no functional change) TBR=zea@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112978

Patch Set 1 #

Total comments: 3

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -72 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/download/download_shelf_context_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/oom_priority_manager_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_observer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/transfer_navigation_resource_handler.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/insecure_content_infobar_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/about_chrome_dialog.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_sub_menu_model_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/page_info_bubble_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/view_id_util_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/page_navigator.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/page_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
please review
9 years ago (2011-12-03 00:08:29 UTC) #1
jam
handing off review to Avi :)
9 years ago (2011-12-04 23:02:05 UTC) #2
Avi (use Gerrit)
Didn't review in full; have a big question. http://codereview.chromium.org/8784006/diff/1/chrome/browser/automation/automation_provider_win.cc File chrome/browser/automation/automation_provider_win.cc (right): http://codereview.chromium.org/8784006/diff/1/chrome/browser/automation/automation_provider_win.cc#newcode373 chrome/browser/automation/automation_provider_win.cc:373: content::Referrer(referrer, ...
9 years ago (2011-12-05 02:33:48 UTC) #3
jam
http://codereview.chromium.org/8784006/diff/1/chrome/browser/external_tab_container_win.cc File chrome/browser/external_tab_container_win.cc (right): http://codereview.chromium.org/8784006/diff/1/chrome/browser/external_tab_container_win.cc#newcode56 chrome/browser/external_tab_container_win.cc:56: #include "third_party/WebKit/Source/WebKit/chromium/public/WebReferrerPolicy.h" On 2011/12/05 02:33:48, Avi wrote: > This ...
9 years ago (2011-12-05 03:23:00 UTC) #4
Avi (use Gerrit)
Oooh. Yes, that's what I meant; sorry for the confusion. LGTM.
9 years ago (2011-12-05 03:29:12 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-05 14:47:26 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698