Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3220)

Unified Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_utils.cc
diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc
index 3d4b8062b560de68cad3c9ba4cb1f0c1e79935e8..aef020380ed3744c361bda7ed871da295c37350c 100644
--- a/chrome/browser/bookmarks/bookmark_utils.cc
+++ b/chrome/browser/bookmarks/bookmark_utils.cc
@@ -77,8 +77,9 @@ class NewBrowserPageNavigator : public PageNavigator {
const GURL& referrer,
WindowOpenDisposition disposition,
content::PageTransition transition) OVERRIDE {
- return OpenURL(OpenURLParams(url, referrer, disposition, transition,
- false));
+ DCHECK(referrer.is_empty());
+ return OpenURL(OpenURLParams(url, content::Referrer(), disposition,
+ transition, false));
}
virtual TabContents* OpenURL(const OpenURLParams& params) OVERRIDE {
@@ -155,8 +156,9 @@ void OpenAllImpl(const BookmarkNode* node,
disposition = NEW_BACKGROUND_TAB;
else
disposition = initial_disposition;
- (*navigator)->OpenURL(OpenURLParams(node->url(), GURL(), disposition,
- content::PAGE_TRANSITION_AUTO_BOOKMARK, false));
+ (*navigator)->OpenURL(OpenURLParams(node->url(), content::Referrer(),
+ disposition, content::PAGE_TRANSITION_AUTO_BOOKMARK,
+ false));
if (!*opened_url) {
*opened_url = true;
// We opened the first URL which may have opened a new window or clobbered

Powered by Google App Engine
This is Rietveld 408576698