Fix the sync sign in dialog issues for app notifications:

chrome/browser/extensions/app_notify_channel_ui.cc

Index: chrome/browser/extensions/app_notify_channel_ui.cc
===================================================================
--- chrome/browser/extensions/app_notify_channel_ui.cc	(revision 112743)
+++ chrome/browser/extensions/app_notify_channel_ui.cc	(working copy)
@@ -114,7 +114,9 @@
 void AppNotifyChannelUIImpl::OnInfoBarResult(bool accepted) {
   if (accepted) {
     StartObservingSync();
-    browser_->ShowSyncSetup();
+    ProfileSyncService* service =
+        browser_->profile()->GetOriginalProfile()->GetProfileSyncService();
+    service->ShowLoginDialog();

[Andrew T Wilson (Slow), 2011/12/02 21:55:41]

Do we need to worry about non-desktop platforms? Should we be prompting the user
for credentials on CrOS?

[Munjal (Google), 2011/12/03 01:25:33]

On CrOS, the user will be logged in after Chrome updates and at that time the
OAuth2 login token will be generated and hence this method will never execute.

Having said that, I want to think about this more and there is anyway anotehr
fix to this code that is needed. So let me address that in a separate patch in
which I do that fix.

   } else {
     delegate_->OnSyncSetupResult(false);
   }