Fix the sync sign in dialog issues for app notifications:

chrome/browser/extensions/app_notify_channel_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/app_notify_channel_ui.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/infobars/infobar_tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
@@ skipping 96 matching lines @@
   }
 
   InfoBarTabHelper* helper = wrapper_->infobar_tab_helper();
   helper->AddInfoBar(new AppNotifyChannelUIImpl::InfoBar(
       this, helper, app_name_));
 }
 
 void AppNotifyChannelUIImpl::OnInfoBarResult(bool accepted) {
   if (accepted) {
     StartObservingSync();
-    browser_->ShowSyncSetup();
+    ProfileSyncService* service =
+        browser_->profile()->GetOriginalProfile()->GetProfileSyncService();
+    service->ShowLoginDialog();

[Andrew T Wilson (Slow), 2011/12/02 21:55:41]

Do we need to worry about non-desktop platforms? Should we be prompting the user
for credentials on CrOS?

[Munjal (Google), 2011/12/03 01:25:33]

On CrOS, the user will be logged in after Chrome updates and at that time the
OAuth2 login token will be generated and hence this method will never execute.

Having said that, I want to think about this more and there is anyway anotehr
fix to this code that is needed. So let me address that in a separate patch in
which I do that fix.

   } else {
     delegate_->OnSyncSetupResult(false);
   }
 }
 
 void AppNotifyChannelUIImpl::OnStateChanged() {
   ProfileSyncService* sync_service =
       browser_->profile()->GetProfileSyncService();
   bool finished = got_first_sync_callback_ && !sync_service->SetupInProgress();
   got_first_sync_callback_ = true;
 
   if (finished) {
     StopObservingSync();
     delegate_->OnSyncSetupResult(sync_service->HasSyncSetupCompleted());
   }
 }
 
 void AppNotifyChannelUIImpl::StartObservingSync() {
   CHECK(!observing_sync_);
   observing_sync_ = true;
   browser_->profile()->GetProfileSyncService()->AddObserver(this);
 }
 
 void AppNotifyChannelUIImpl::StopObservingSync() {
   CHECK(observing_sync_);
   observing_sync_ = false;
   browser_->profile()->GetProfileSyncService()->RemoveObserver(this);
 }