Chromium side of IDBIndex.count() and IDBObjectStore.count()

content/common/indexed_db_messages.h

Index: content/common/indexed_db_messages.h
diff --git a/content/common/indexed_db_messages.h b/content/common/indexed_db_messages.h
index 07784f3f91d7861708f04b3340e5ad4e8401f871..af05eb65834b8c788d4d1e1b0f709763ae6a0517 100644
--- a/content/common/indexed_db_messages.h
+++ b/content/common/indexed_db_messages.h
@@ -82,6 +82,24 @@ IPC_STRUCT_BEGIN(IndexedDBHostMsg_IndexOpenCursor_Params)
   IPC_STRUCT_MEMBER(int, transaction_id)
 IPC_STRUCT_END()
 
+// Used for counting values within an index IndexedDB.
+IPC_STRUCT_BEGIN(IndexedDBHostMsg_IndexCount_Params)
+  // The response should have this id.
+  IPC_STRUCT_MEMBER(int32, response_id)
+  // The serialized lower key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, lower_key)
+  // The serialized upper key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, upper_key)
+  // Is the lower bound open?
+  IPC_STRUCT_MEMBER(bool, lower_open)

[darin (slow to review), 2011/12/13 00:50:22]

nit: maybe lower_bound_open would be a better name?  i just noticed that you
write "lower bound open" in the comment, so perhaps the name could just say that
too?  then the comment might even be unnecessary?

+  // Is the upper bound open?
+  IPC_STRUCT_MEMBER(bool, upper_open)
+  // The index the index belongs to.
+  IPC_STRUCT_MEMBER(int32, idb_index_id)

[darin (slow to review), 2011/12/13 00:50:22]

nit: is the "idb_" prefix helpful here?  this struct already has IndexedDB in
its name.

actually, i see that there are a number of other structs here that all use
similar naming rules.  for now, you should just be consistent.  maybe there is a
separate task to re-think some of these names.

+  // The transaction this request belongs to.
+  IPC_STRUCT_MEMBER(int, transaction_id)
+IPC_STRUCT_END()
+
 // Used to set a value in an object store.
 IPC_STRUCT_BEGIN(IndexedDBHostMsg_ObjectStorePut_Params)
   // The object store's id.
@@ -134,6 +152,24 @@ IPC_STRUCT_BEGIN(IndexedDBHostMsg_ObjectStoreOpenCursor_Params)
   IPC_STRUCT_MEMBER(int, transaction_id)
 IPC_STRUCT_END()
 
+// Used to count within an IndexedDB object store.
+IPC_STRUCT_BEGIN(IndexedDBHostMsg_ObjectStoreCount_Params)
+  // The response should have this id.
+  IPC_STRUCT_MEMBER(int32, response_id)
+  // The serialized lower key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, lower_key)
+  // The serialized upper key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, upper_key)
+  // Is the lower bound open?
+  IPC_STRUCT_MEMBER(bool, lower_open)
+  // Is the upper bound open?
+  IPC_STRUCT_MEMBER(bool, upper_open)
+  // The object store the cursor belongs to.
+  IPC_STRUCT_MEMBER(int32, idb_object_store_id)
+  // The transaction this request belongs to.
+  IPC_STRUCT_MEMBER(int, transaction_id)
+IPC_STRUCT_END()
+
 // Indexed DB messages sent from the browser to the renderer.
 
 // IDBCallback message handlers.
@@ -329,6 +365,11 @@ IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_IndexOpenKeyCursor,
                             IndexedDBHostMsg_IndexOpenCursor_Params,
                             WebKit::WebExceptionCode /* ec */)
 
+// WebIDBIndex::count() message.
+IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_IndexCount,
+                            IndexedDBHostMsg_IndexCount_Params,
+                            WebKit::WebExceptionCode /* ec */)
+
 // WebIDBIndex::getObject() message.
 IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_IndexGetObject,
                             int32, /* idb_index_id */
@@ -417,6 +458,11 @@ IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_ObjectStoreOpenCursor,
                             IndexedDBHostMsg_ObjectStoreOpenCursor_Params,
                             WebKit::WebExceptionCode /* ec */)
 
+// WebIDBObjectStore::count() message.
+IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_ObjectStoreCount,
+                            IndexedDBHostMsg_ObjectStoreCount_Params,
+                            WebKit::WebExceptionCode /* ec */)
+
 // WebIDBObjectStore::~WebIDBObjectStore() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_ObjectStoreDestroyed,
                      int32 /* idb_object_store_id */)