Chromium side of IDBIndex.count() and IDBObjectStore.count()

content/common/indexed_db_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Message definition file, included multiple times, hence no include guard.
 
 #include <vector>
 
 #include "content/common/indexed_db_key.h"
 #include "content/common/indexed_db_param_traits.h"
@@ skipping 64 matching lines @@
   // Is the upper bound open?
   IPC_STRUCT_MEMBER(bool, upper_open)
   // The direction of this cursor.
   IPC_STRUCT_MEMBER(int32, direction)
   // The index the index belongs to.
   IPC_STRUCT_MEMBER(int32, idb_index_id)
   // The transaction this request belongs to.
   IPC_STRUCT_MEMBER(int, transaction_id)
 IPC_STRUCT_END()
 
+// Used for counting values within an index IndexedDB.
+IPC_STRUCT_BEGIN(IndexedDBHostMsg_IndexCount_Params)
+  // The response should have this id.
+  IPC_STRUCT_MEMBER(int32, response_id)
+  // The serialized lower key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, lower_key)
+  // The serialized upper key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, upper_key)
+  // Is the lower bound open?
+  IPC_STRUCT_MEMBER(bool, lower_open)

[darin (slow to review), 2011/12/13 00:50:22]

nit: maybe lower_bound_open would be a better name?  i just noticed that you
write "lower bound open" in the comment, so perhaps the name could just say that
too?  then the comment might even be unnecessary?

+  // Is the upper bound open?
+  IPC_STRUCT_MEMBER(bool, upper_open)
+  // The index the index belongs to.
+  IPC_STRUCT_MEMBER(int32, idb_index_id)

[darin (slow to review), 2011/12/13 00:50:22]

nit: is the "idb_" prefix helpful here?  this struct already has IndexedDB in
its name.

actually, i see that there are a number of other structs here that all use
similar naming rules.  for now, you should just be consistent.  maybe there is a
separate task to re-think some of these names.

+  // The transaction this request belongs to.
+  IPC_STRUCT_MEMBER(int, transaction_id)
+IPC_STRUCT_END()
+
 // Used to set a value in an object store.
 IPC_STRUCT_BEGIN(IndexedDBHostMsg_ObjectStorePut_Params)
   // The object store's id.
   IPC_STRUCT_MEMBER(int32, idb_object_store_id)
   // The id any response should contain.
   IPC_STRUCT_MEMBER(int32, response_id)
   // The value to set.
   IPC_STRUCT_MEMBER(content::SerializedScriptValue, serialized_value)
   // The key to set it on (may not be "valid"/set in some cases).
   IPC_STRUCT_MEMBER(IndexedDBKey, key)
@@ skipping 32 matching lines @@
   // Is the upper bound open?
   IPC_STRUCT_MEMBER(bool, upper_open)
   // The direction of this cursor.
   IPC_STRUCT_MEMBER(int32, direction)
   // The object store the cursor belongs to.
   IPC_STRUCT_MEMBER(int32, idb_object_store_id)
   // The transaction this request belongs to.
   IPC_STRUCT_MEMBER(int, transaction_id)
 IPC_STRUCT_END()
 
+// Used to count within an IndexedDB object store.
+IPC_STRUCT_BEGIN(IndexedDBHostMsg_ObjectStoreCount_Params)
+  // The response should have this id.
+  IPC_STRUCT_MEMBER(int32, response_id)
+  // The serialized lower key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, lower_key)
+  // The serialized upper key.
+  IPC_STRUCT_MEMBER(IndexedDBKey, upper_key)
+  // Is the lower bound open?
+  IPC_STRUCT_MEMBER(bool, lower_open)
+  // Is the upper bound open?
+  IPC_STRUCT_MEMBER(bool, upper_open)
+  // The object store the cursor belongs to.
+  IPC_STRUCT_MEMBER(int32, idb_object_store_id)
+  // The transaction this request belongs to.
+  IPC_STRUCT_MEMBER(int, transaction_id)
+IPC_STRUCT_END()
+
 // Indexed DB messages sent from the browser to the renderer.
 
 // IDBCallback message handlers.
 IPC_MESSAGE_CONTROL5(IndexedDBMsg_CallbacksSuccessIDBCursor,
                      int32 /* response_id */,
                      int32 /* cursor_id */,
                      IndexedDBKey /* key */,
                      IndexedDBKey /* primary key */,
                      content::SerializedScriptValue /* script_value */)
 IPC_MESSAGE_CONTROL5(IndexedDBMsg_CallbacksSuccessCursorContinue,
@@ skipping 175 matching lines @@
 // WebIDBIndex::openObjectCursor() message.
 IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_IndexOpenObjectCursor,
                             IndexedDBHostMsg_IndexOpenCursor_Params,
                             WebKit::WebExceptionCode /* ec */)
 
 // WebIDBIndex::openKeyCursor() message.
 IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_IndexOpenKeyCursor,
                             IndexedDBHostMsg_IndexOpenCursor_Params,
                             WebKit::WebExceptionCode /* ec */)
 
+// WebIDBIndex::count() message.
+IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_IndexCount,
+                            IndexedDBHostMsg_IndexCount_Params,
+                            WebKit::WebExceptionCode /* ec */)
+
 // WebIDBIndex::getObject() message.
 IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_IndexGetObject,
                             int32, /* idb_index_id */
                             int32, /* response_id */
                             IndexedDBKey, /* key */
                             int32, /* transaction_id */
                             WebKit::WebExceptionCode /* ec */)
 
 // WebIDBIndex::getKey() message.
 IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_IndexGetKey,
@@ skipping 68 matching lines @@
                             int32, /* idb_object_store_id */
                             string16, /* name */
                             int32, /* transaction_id */
                             WebKit::WebExceptionCode /* ec */)
 
 // WebIDBObjectStore::openCursor() message.
 IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_ObjectStoreOpenCursor,
                             IndexedDBHostMsg_ObjectStoreOpenCursor_Params,
                             WebKit::WebExceptionCode /* ec */)
 
+// WebIDBObjectStore::count() message.
+IPC_SYNC_MESSAGE_CONTROL1_1(IndexedDBHostMsg_ObjectStoreCount,
+                            IndexedDBHostMsg_ObjectStoreCount_Params,
+                            WebKit::WebExceptionCode /* ec */)
+
 // WebIDBObjectStore::~WebIDBObjectStore() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_ObjectStoreDestroyed,
                      int32 /* idb_object_store_id */)
 
 // WebIDBDatabase::~WebIDBCursor() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_CursorDestroyed,
                      int32 /* idb_cursor_id */)
 
 // IDBTransaction::ObjectStore message.
 IPC_SYNC_MESSAGE_CONTROL2_2(IndexedDBHostMsg_TransactionObjectStore,
@@ skipping 11 matching lines @@
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_TransactionAbort,
                      int32 /* idb_transaction_id */)
 
 // IDBTransaction::DidCompleteTaskEvents() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_TransactionDidCompleteTaskEvents,
                      int32 /* idb_transaction_id */)
 
 // WebIDBTransaction::~WebIDBTransaction() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_TransactionDestroyed,
                      int32 /* idb_transaction_id */)