Issue 8777003: Move decision if we need to use WASAPI or wave out into separate function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8777003: Move decision if we need to use WASAPI or wave out into separate function. (Closed)

Created:
9 years ago by enal

Modified:
9 years ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Move decision if we need to use WASAPI or wave out into separate function. Minor Windows-only code cleanup. That also fixes broken sound on Windows Server 2003. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112860

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
M	media/audio/audio_util.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	media/audio/audio_util.cc	View	1	4 chunks	+13 lines, -3 lines	0 comments	Download
M	media/audio/win/audio_manager_win.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

lgtm http://codereview.chromium.org/8777003/diff/1/media/audio/audio_util.h File media/audio/audio_util.h (right): http://codereview.chromium.org/8777003/diff/1/media/audio/audio_util.h#newcode112 media/audio/audio_util.h:112: MEDIA_EXPORT bool WindowsSupportWASAPI(); nit: maybe IsWASAPISupported() in line ...

9 years ago (2011-12-02 22:23:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/8777003/4001

9 years ago (2011-12-02 22:40:50 UTC) #3

Change committed as 112860

Expand Messages | Collapse Messages