[ntp4] Set login_status_url dynamically to prevent a javascript console warning.

[ntp4] Set login_status_url dynamically to prevent a javascript console warning.

BUG=105997
TEST=Open NTP, verify that no warnings appear in console.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112810

[csilv, 2011-12-02 18:20:42]

+estade, +dbeam for review

[Dan Beam, 2011-12-02 18:29:48]

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
chrome/browser/resources/ntp4/new_tab.js:127: var learnMoreLink =
loginBubble.querySelector('#login-status-learn-more');
$('login-status-learn-more')

[csilv, 2011-12-02 18:47:10]

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
chrome/browser/resources/ntp4/new_tab.js:127: var learnMoreLink =
loginBubble.querySelector('#login-status-learn-more');
On 2011/12/02 18:29:48, Dan Beam wrote:
> $('login-status-learn-more')

This won't work.  At this point, the element is no longer in the page, it's in
bubbleContent which has not yet been added to the page.  Same with the existing
lines 130, 135.  But if we really want to do this, we can do it by moving lines
123-125 down to line 137.

[Dan Beam, 2011-12-02 19:05:36]

lgtm

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
chrome/browser/resources/ntp4/new_tab.js:127: var learnMoreLink =
loginBubble.querySelector('#login-status-learn-more');
On 2011/12/02 18:47:10, csilv wrote:
> On 2011/12/02 18:29:48, Dan Beam wrote:
> > $('login-status-learn-more')
> 
> This won't work.  At this point, the element is no longer in the page, it's in
> bubbleContent which has not yet been added to the page.  Same with the
existing
> lines 130, 135.  But if we really want to do this, we can do it by moving
lines
> 123-125 down to line 137.

That's fine, ignore me (if the container isn't in the DOM yet).

[Evan Stade, 2011-12-02 20:51:41]

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
chrome/browser/resources/ntp4/new_tab.js:127: var learnMoreLink =
loginBubble.querySelector('#login-status-learn-more');
or you can do this before L123

[csilv, 2011-12-02 21:20:56]

On 2011/12/02 20:51:41, Evan Stade wrote:
>
http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
> File chrome/browser/resources/ntp4/new_tab.js (right):
> 
>
http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
> chrome/browser/resources/ntp4/new_tab.js:127: var learnMoreLink =
> loginBubble.querySelector('#login-status-learn-more');
> or you can do this before L123

I think that would be worse than the current CL because it would create
inconsistency with how this element is configured, and the others.  So I'll just
go ahead and make the cosmetic change.

[csilv, 2011-12-02 21:37:25]

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/8776054/diff/1/chrome/browser/resources/ntp4/n...
chrome/browser/resources/ntp4/new_tab.js:127: var learnMoreLink =
loginBubble.querySelector('#login-status-learn-more');
On 2011/12/02 20:51:41, Evan Stade wrote:
> or you can do this before L123

Done.

[Evan Stade, 2011-12-02 21:53:18]

LGTM