Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5135)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 8776054: [ntp4] Set login_status_url dynamically to prevent a javascript console warning. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/new_tab.js
===================================================================
--- chrome/browser/resources/ntp4/new_tab.js (revision 112581)
+++ chrome/browser/resources/ntp4/new_tab.js (working copy)
@@ -120,18 +120,17 @@
loginBubble.deactivateToDismissDelay = 2000;
loginBubble.setCloseButtonVisible(false);
+ $('login-status-learn-more').href =
+ localStrings.getString('login_status_url');
+ $('login-status-advanced').onclick = function() {
+ chrome.send('showAdvancedLoginUI');
+ }
+ $('login-status-dismiss').onclick = loginBubble.hide.bind(loginBubble);
+
var bubbleContent = $('login-status-bubble-contents');
loginBubble.content = bubbleContent;
bubbleContent.hidden = false;
- var advancedButton = loginBubble.querySelector('#login-status-advanced');
- advancedButton.onclick = function() {
- chrome.send('showAdvancedLoginUI');
- }
-
- var dismissButton = loginBubble.querySelector('#login-status-dismiss');
- dismissButton.onclick = loginBubble.hide.bind(loginBubble);
-
// The anchor node won't be updated until updateLogin is called so don't
// show the bubble yet.
shouldShowLoginBubble = true;
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698