Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 8776045: Fix special handling of DefineOwnProperty on arrays. (Closed)

Created:
9 years ago by Michael Starzinger
Modified:
9 years ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Visibility:
Public.

Description

Fix special handling of DefineOwnProperty on arrays. According to the ES5 spec the implementation of DefineOwnProperty() has to special case handling of arrays. This implementation correctly handles definitions of array index properties and redefinitions of the length property. R=svenpanne@chromium.org BUG=v8:1756 TEST=test262 Committed: http://code.google.com/p/v8/source/detail?r=10149

Patch Set 1 #

Patch Set 2 : Further fix special handling. #

Patch Set 3 : Further fix special handling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -184 lines) Patch
M src/v8natives.js View 1 2 3 chunks +96 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +1 line, -178 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
PTAL. This re-lands an improved version of http://codereview.chromium.org/8221002.
9 years ago (2011-12-02 16:13:06 UTC) #1
danno
lgtm
9 years ago (2011-12-02 16:24:46 UTC) #2
Sven Panne
9 years ago (2011-12-05 09:38:14 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698