Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 8221002: Fix special handling of DefineOwnProperty on arrays. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger
Modified:
9 years, 2 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix special handling of DefineOwnProperty on arrays. According to the ES5 spec the implementation of DefineOwnProperty() has to special case handling of arrays. This is a preliminary implementation correctly handling definition of array index properties, defining length properties is not completely covered yet. R=rossberg@chromium.org TEST=test262 Committed: http://code.google.com/p/v8/source/detail?r=9596

Patch Set 1 #

Patch Set 2 : Fix regression in TypeError description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -715 lines) Patch
M src/v8natives.js View 1 2 chunks +58 lines, -6 lines 0 comments Download
M test/test262/test262.status View 7 chunks +79 lines, -709 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
With this fix the situation looks like this. Not enough to bump us to the ...
9 years, 2 months ago (2011-10-10 13:01:57 UTC) #1
rossberg
9 years, 2 months ago (2011-10-10 13:12:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698