Issue 8776041: Fix use-after-free. OnChildDied deletes the current object, so we shouldn't call member functions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8776041: Fix use-after-free. OnChildDied deletes the current object, so we shouldn't call member functions... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix use-after-free. OnChildDied deletes the current object, so we shouldn't call member functions afterwards. I'm refactoring this code in another cl, but figured I'd fix this separately to make things clearer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112767

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	content/browser/browser_child_process_host.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages