content/browser/browser_child_process_host.cc - Issue 8776041: Fix use-after-free. OnChildDied deletes the current object, so we shouldn't call member functions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_child_process_host.cc

Issue 8776041: Fix use-after-free. OnChildDied deletes the current object, so we shouldn't call member functions... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/browser_child_process_host.cc

===================================================================

--- content/browser/browser_child_process_host.cc (revision 112509)

+++ content/browser/browser_child_process_host.cc (working copy)

@@ -228,9 +228,11 @@

unsigned long exit_code = 0;

GetExitCodeProcess(waitable_event->Release(), &exit_code);

delete waitable_event;

- if (exit_code == STILL_ACTIVE)

+ if (exit_code == STILL_ACTIVE) {

OnChildDied();

- BrowserChildProcessHost::OnChildDisconnected();

+ } else {

+ BrowserChildProcessHost::OnChildDisconnected();

+ }

#endif

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »