Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8776033: Support multi-byte nop instructions as recommended by (Closed)

Created:
9 years ago by Erik Corry
Modified:
9 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Support multi-byte nop instructions as recommended by the optimization guides from AMD and Intel. Committed: http://code.google.com/p/v8/source/detail?r=10134

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -16 lines) Patch
M src/ia32/assembler-ia32.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +85 lines, -2 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 4 chunks +29 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years ago (2011-12-02 00:21:20 UTC) #1
Michael Starzinger
9 years ago (2011-12-02 08:51:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698