Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 8776033: Support multi-byte nop instructions as recommended by (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/assembler-ia32.cc ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 // ----------------------------------- 251 // -----------------------------------
252 Generate_DebugBreakCallHelper(masm, edi.bit(), 0, false); 252 Generate_DebugBreakCallHelper(masm, edi.bit(), 0, false);
253 } 253 }
254 254
255 255
256 void Debug::GenerateSlot(MacroAssembler* masm) { 256 void Debug::GenerateSlot(MacroAssembler* masm) {
257 // Generate enough nop's to make space for a call instruction. 257 // Generate enough nop's to make space for a call instruction.
258 Label check_codesize; 258 Label check_codesize;
259 __ bind(&check_codesize); 259 __ bind(&check_codesize);
260 __ RecordDebugBreakSlot(); 260 __ RecordDebugBreakSlot();
261 for (int i = 0; i < Assembler::kDebugBreakSlotLength; i++) { 261 __ Nop(Assembler::kDebugBreakSlotLength);
262 __ nop();
263 }
264 ASSERT_EQ(Assembler::kDebugBreakSlotLength, 262 ASSERT_EQ(Assembler::kDebugBreakSlotLength,
265 masm->SizeOfCodeGeneratedSince(&check_codesize)); 263 masm->SizeOfCodeGeneratedSince(&check_codesize));
266 } 264 }
267 265
268 266
269 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) { 267 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) {
270 // In the places where a debug break slot is inserted no registers can contain 268 // In the places where a debug break slot is inserted no registers can contain
271 // object pointers. 269 // object pointers.
272 Generate_DebugBreakCallHelper(masm, 0, 0, true); 270 Generate_DebugBreakCallHelper(masm, 0, 0, true);
273 } 271 }
(...skipping 30 matching lines...) Expand all
304 302
305 const bool Debug::kFrameDropperSupported = true; 303 const bool Debug::kFrameDropperSupported = true;
306 304
307 #undef __ 305 #undef __
308 306
309 #endif // ENABLE_DEBUGGER_SUPPORT 307 #endif // ENABLE_DEBUGGER_SUPPORT
310 308
311 } } // namespace v8::internal 309 } } // namespace v8::internal
312 310
313 #endif // V8_TARGET_ARCH_IA32 311 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32.cc ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698