Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 8776026: Make accessible scroll position attributes more generic and (Closed)

Created:
9 years ago by dmazzoni
Modified:
9 years ago
Reviewers:
tony
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, davidbarr+watch_chromium.org, jam, yuzo+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Make accessible scroll position attributes more generic and add attributes for the min and max scroll position, as the first step towards implementing accessible scrolling APIs. BUG=104468 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/glue/webaccessibility.h View 1 chunk +7 lines, -3 lines 0 comments Download
M webkit/glue/webaccessibility.cc View 2 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmazzoni
tony: please review - just tiny changes to webkit/glue and one file that uses the ...
9 years ago (2011-12-01 23:13:14 UTC) #1
tony
LGTM
9 years ago (2011-12-01 23:14:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8776026/1
9 years ago (2011-12-01 23:15:21 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-02 01:23:11 UTC) #4
Try job failure for 8776026-1 (retry) (previous was lost) on win_rel for step
"update".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698