Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: webkit/glue/webaccessibility.cc

Issue 8776026: Make accessible scroll position attributes more generic and (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webaccessibility.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webaccessibility.cc
===================================================================
--- webkit/glue/webaccessibility.cc (revision 112482)
+++ webkit/glue/webaccessibility.cc (working copy)
@@ -582,12 +582,24 @@
++iter) {
std::string value = IntToString(iter->second);
switch (iter->first) {
- case ATTR_DOC_SCROLLX:
- result += " scrollx=" + value;
+ case ATTR_SCROLL_X:
+ result += " scroll_x=" + value;
break;
- case ATTR_DOC_SCROLLY:
- result += " scrolly=" + value;
+ case ATTR_SCROLL_X_MIN:
+ result += " scroll_x_min=" + value;
break;
+ case ATTR_SCROLL_X_MAX:
+ result += " scroll_x_max=" + value;
+ break;
+ case ATTR_SCROLL_Y:
+ result += " scroll_y=" + value;
+ break;
+ case ATTR_SCROLL_Y_MIN:
+ result += " scroll_y_min=" + value;
+ break;
+ case ATTR_SCROLL_Y_MAX:
+ result += " scroll_y_max=" + value;
+ break;
case ATTR_HIERARCHICAL_LEVEL:
result += " level=" + value;
break;
@@ -924,8 +936,16 @@
string_attributes[ATTR_DOC_DOCTYPE] = doctype.name();
const gfx::Size& scroll_offset = document.frame()->scrollOffset();
- int_attributes[ATTR_DOC_SCROLLX] = scroll_offset.width();
- int_attributes[ATTR_DOC_SCROLLY] = scroll_offset.height();
+ int_attributes[ATTR_SCROLL_X] = scroll_offset.width();
+ int_attributes[ATTR_SCROLL_Y] = scroll_offset.height();
+
+ const gfx::Size& min_offset = document.frame()->minimumScrollOffset();
+ int_attributes[ATTR_SCROLL_X_MIN] = min_offset.width();
+ int_attributes[ATTR_SCROLL_Y_MIN] = min_offset.height();
+
+ const gfx::Size& max_offset = document.frame()->maximumScrollOffset();
+ int_attributes[ATTR_SCROLL_X_MAX] = max_offset.width();
+ int_attributes[ATTR_SCROLL_Y_MAX] = max_offset.height();
}
if (role == WebAccessibility::ROLE_TABLE) {
« no previous file with comments | « webkit/glue/webaccessibility.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698