Switch the nop pnacl x86-64 IRT shim to the real one generated from IDL.

Switch the nop pnacl x86-64 IRT shim to the real one generated from IDL.

We add pnacl_irt_shim to the Implicit Libs for pnacl x86-64 runs
so that we get the freshest version instead of whatever is in the toolchain
tarball.


R=robertm@google.com,sehr@google.com
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2413
TEST= ./scons bitcode=1 platform=x86-64 chrome_browser_tests

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=7353

[jvoung - send to chromium..., 2011-12-01 22:33:00]

tested locally -- currently the pdf test still fails:
http://codereview.chromium.org/8775028/

[robertm, 2011-12-01 22:55:43]

A few nits below

http://codereview.chromium.org/8776023/diff/1/pnacl/build.sh
File pnacl/build.sh (right):

http://codereview.chromium.org/8776023/diff/1/pnacl/build.sh#newcode3053
pnacl/build.sh:3053: RunWithLog "sdk.irt.shim" \
this looks like churn why not stick with the original

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/na...
File src/untrusted/pnacl_irt_shim/nacl.scons (right):

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/na...
src/untrusted/pnacl_irt_shim/nacl.scons:20: # This Glob doesn't quite work for
picking up input dependencies.
so how do we work around it not working

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/pn...
File src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp (right):

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/pn...
src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:2: # Use of this source code is
governed by a BSD-style license that can be
let's move the gyp stuff to a different CL

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/sh...
File src/untrusted/pnacl_irt_shim/shim_ppapi.c (right):

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/sh...
src/untrusted/pnacl_irt_shim/shim_ppapi.c:30: */
moving the comment before the arg is uncommon

[jvoung - send to chromium..., 2011-12-01 23:35:34]

http://codereview.chromium.org/8776023/diff/1/pnacl/build.sh
File pnacl/build.sh (right):

http://codereview.chromium.org/8776023/diff/1/pnacl/build.sh#newcode3053
pnacl/build.sh:3053: RunWithLog "sdk.irt.shim" \
On 2011/12/01 22:55:43, robertm wrote:
> this looks like churn why not stick with the original

I think this was to make the implicit-libs change work, which makes it so that
when you run:

./scons bitcode=1 platform=x86-64 chrome_browser_tests

It would rebuild the latest libpnacl_irt_shim.a in the pnacl-clang directory
before linking together the browser nexes and use that, rather than the
libpnacl_irt_shim.a that was downloaded from the tarball (built here).

We could leave it like the original, but then we'd need to do a toolchain DEPS
update before it gets the newer shim.

Thoughts?

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/na...
File src/untrusted/pnacl_irt_shim/nacl.scons (right):

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/na...
src/untrusted/pnacl_irt_shim/nacl.scons:20: # This Glob doesn't quite work for
picking up input dependencies.
On 2011/12/01 22:55:43, robertm wrote:
> so how do we work around it not working

duh, should have been env.Glob() instead of Glob() to be able to fill in
${SOURCE_ROOT}. Fixed.

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/pn...
File src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp (right):

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/pn...
src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:2: # Use of this source code is
governed by a BSD-style license that can be
On 2011/12/01 22:55:43, robertm wrote:
> let's move the gyp stuff to a different CL

Done.

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/sh...
File src/untrusted/pnacl_irt_shim/shim_ppapi.c (right):

http://codereview.chromium.org/8776023/diff/1/src/untrusted/pnacl_irt_shim/sh...
src/untrusted/pnacl_irt_shim/shim_ppapi.c:30: */
On 2011/12/01 22:55:43, robertm wrote:
> moving the comment before the arg is uncommon

Done.

[robertm, 2011-12-01 23:58:43]

LGTM

http://codereview.chromium.org/8776023/diff/1/pnacl/build.sh
File pnacl/build.sh (right):

http://codereview.chromium.org/8776023/diff/1/pnacl/build.sh#newcode3053
pnacl/build.sh:3053: RunWithLog "sdk.irt.shim" \
Ok that is fine then - but  maybe add a brief comment

On 2011/12/01 23:35:34, jvoung wrote:
> On 2011/12/01 22:55:43, robertm wrote:
> > this looks like churn why not stick with the original
> 
> I think this was to make the implicit-libs change work, which makes it so that
> when you run:
> 
> ./scons bitcode=1 platform=x86-64 chrome_browser_tests
> 
> It would rebuild the latest libpnacl_irt_shim.a in the pnacl-clang directory
> before linking together the browser nexes and use that, rather than the
> libpnacl_irt_shim.a that was downloaded from the tarball (built here).
> 
> We could leave it like the original, but then we'd need to do a toolchain DEPS
> update before it gets the newer shim.
> 
> Thoughts?

[sehr (please use chromium), 2011-12-02 03:13:54]

lgtm