tests/pnacl_client_translator/nacl.scons - Issue 8776023: Switch the nop pnacl x86-64 IRT shim to the real one generated from IDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/pnacl_client_translator/nacl.scons

Issue 8776023: Switch the nop pnacl x86-64 IRT shim to the real one generated from IDL. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: disable pnacl_example_browser for x86-64 until shim updated Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/pnacl_client_translator/nacl.scons

diff --git a/tests/pnacl_client_translator/nacl.scons b/tests/pnacl_client_translator/nacl.scons

index 99a1fb4964e4ca47c0712f76d934b559634a46bb..3c5b5b9daa4a423261b6f34bcbe80c421619799e 100644

--- a/tests/pnacl_client_translator/nacl.scons

+++ b/tests/pnacl_client_translator/nacl.scons

@@ -167,7 +167,10 @@ bitcode_env.AddNodeToTestSuite(node,

['chrome_browser_tests'],

'run_pnacl_example_browser_test',

is_broken=(

- bitcode_env.PPAPIBrowserTesterIsBroken()))

+ bitcode_env.PPAPIBrowserTesterIsBroken() or

+ # Re-enable when coordinator uses shim

+ # and toolchain tarball has real shim.

+ bitcode_env.Bit('target_x86_64')))

#### Test error handling.

@@ -213,4 +216,7 @@ bitcode_env.AddNodeToTestSuite(node,