Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5205)

Unified Diff: chrome/common/extensions/extension_permission_set_unittest.cc

Issue 8776022: Move app notification getChannel API out of experimental (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: another unit test fix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_permission_set.cc ('k') | chrome/renderer/resources/extensions/app.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_permission_set_unittest.cc
diff --git a/chrome/common/extensions/extension_permission_set_unittest.cc b/chrome/common/extensions/extension_permission_set_unittest.cc
index a797c7649dd71cc6424aad7b997eed44dc95a347..8eb1b7895d35ff2ba0fe382351f24badb1ee983e 100644
--- a/chrome/common/extensions/extension_permission_set_unittest.cc
+++ b/chrome/common/extensions/extension_permission_set_unittest.cc
@@ -142,6 +142,7 @@ TEST(ExtensionAPIPermissionTest, Aliases) {
TEST(ExtensionAPIPermissionTest, HostedAppPermissions) {
ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
ExtensionAPIPermissionSet hosted_perms;
+ hosted_perms.insert(ExtensionAPIPermission::kAppNotifications);
hosted_perms.insert(ExtensionAPIPermission::kBackground);
hosted_perms.insert(ExtensionAPIPermission::kClipboardRead);
hosted_perms.insert(ExtensionAPIPermission::kClipboardWrite);
@@ -168,6 +169,7 @@ TEST(ExtensionAPIPermissionTest, HostedAppPermissions) {
TEST(ExtensionAPIPermissionTest, PlatformAppPermissions) {
ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
ExtensionAPIPermissionSet blacklist;
+ blacklist.insert(ExtensionAPIPermission::kAppNotifications);
blacklist.insert(ExtensionAPIPermission::kChromeAuthPrivate);
blacklist.insert(ExtensionAPIPermission::kChromePrivate);
blacklist.insert(ExtensionAPIPermission::kCookie);
@@ -629,6 +631,7 @@ TEST(ExtensionPermissionSetTest, PermissionMessages) {
// These are considered "nuisance" or "trivial" permissions that don't need
// a prompt.
+ skip.insert(ExtensionAPIPermission::kAppNotifications);
skip.insert(ExtensionAPIPermission::kContextMenus);
skip.insert(ExtensionAPIPermission::kIdle);
skip.insert(ExtensionAPIPermission::kNotification);
« no previous file with comments | « chrome/common/extensions/extension_permission_set.cc ('k') | chrome/renderer/resources/extensions/app.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698