Move app notification getChannel API out of experimental

chrome/common/extensions/extension_permission_set_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_permission_set.h"
 
 #include "base/json/json_value_serializer.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/utf_string_conversions.h"
@@ skipping 124 matching lines @@
       ExtensionAPIPermission::kUnlimitedStorage)->name());
   EXPECT_EQ(ExtensionAPIPermission::kUnlimitedStorage,
             info->GetByName("unlimitedStorage")->id());
   EXPECT_EQ(ExtensionAPIPermission::kUnlimitedStorage,
             info->GetByName("unlimited_storage")->id());
 }
 
 TEST(ExtensionAPIPermissionTest, HostedAppPermissions) {
   ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
   ExtensionAPIPermissionSet hosted_perms;
+  hosted_perms.insert(ExtensionAPIPermission::kAppNotifications);
   hosted_perms.insert(ExtensionAPIPermission::kBackground);
   hosted_perms.insert(ExtensionAPIPermission::kClipboardRead);
   hosted_perms.insert(ExtensionAPIPermission::kClipboardWrite);
   hosted_perms.insert(ExtensionAPIPermission::kChromeAuthPrivate);
   hosted_perms.insert(ExtensionAPIPermission::kChromePrivate);
   hosted_perms.insert(ExtensionAPIPermission::kExperimental);
   hosted_perms.insert(ExtensionAPIPermission::kGeolocation);
   hosted_perms.insert(ExtensionAPIPermission::kNotification);
   hosted_perms.insert(ExtensionAPIPermission::kUnlimitedStorage);
   hosted_perms.insert(ExtensionAPIPermission::kWebstorePrivate);
 
   ExtensionAPIPermissionSet perms = info->GetAll();
   size_t count = 0;
   for (ExtensionAPIPermissionSet::iterator i = perms.begin();
        i != perms.end(); ++i) {
     count += hosted_perms.count(*i);
     EXPECT_EQ(hosted_perms.count(*i) > 0,
               info->GetByID(*i)->supports_hosted_apps());
   }
 
   EXPECT_EQ(hosted_perms.size(), count);
 }
 
 TEST(ExtensionAPIPermissionTest, PlatformAppPermissions) {
   ExtensionPermissionsInfo* info = ExtensionPermissionsInfo::GetInstance();
   ExtensionAPIPermissionSet blacklist;
+  blacklist.insert(ExtensionAPIPermission::kAppNotifications);
   blacklist.insert(ExtensionAPIPermission::kChromeAuthPrivate);
   blacklist.insert(ExtensionAPIPermission::kChromePrivate);
   blacklist.insert(ExtensionAPIPermission::kCookie);
   blacklist.insert(ExtensionAPIPermission::kTab);
   blacklist.insert(ExtensionAPIPermission::kWebNavigation);
   blacklist.insert(ExtensionAPIPermission::kWebRequest);
   blacklist.insert(ExtensionAPIPermission::kWebRequestBlocking);
   blacklist.insert(ExtensionAPIPermission::kWebSocketProxyPrivate);
 
   ExtensionAPIPermissionSet perms = info->GetAll();
@@ skipping 441 matching lines @@
   }
 }
 
 TEST(ExtensionPermissionSetTest, PermissionMessages) {
   // Ensure that all permissions that needs to show install UI actually have
   // strings associated with them.
   ExtensionAPIPermissionSet skip;
 
   // These are considered "nuisance" or "trivial" permissions that don't need
   // a prompt.
+  skip.insert(ExtensionAPIPermission::kAppNotifications);
   skip.insert(ExtensionAPIPermission::kContextMenus);
   skip.insert(ExtensionAPIPermission::kIdle);
   skip.insert(ExtensionAPIPermission::kNotification);
   skip.insert(ExtensionAPIPermission::kUnlimitedStorage);
   skip.insert(ExtensionAPIPermission::kTts);
 
   // TODO(erikkay) add a string for this permission.
   skip.insert(ExtensionAPIPermission::kBackground);
 
   skip.insert(ExtensionAPIPermission::kClipboardWrite);
@@ skipping 480 matching lines @@
   AddPattern(&non_empty_extent, "http://www.google.com/*");
 
   perm_set = new ExtensionPermissionSet(
       empty_apis, non_empty_extent, empty_extent);
   EXPECT_FALSE(perm_set->IsEmpty());
 
   perm_set = new ExtensionPermissionSet(
       empty_apis, empty_extent, non_empty_extent);
   EXPECT_FALSE(perm_set->IsEmpty());
 }