Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 8776022: Move app notification getChannel API out of experimental (Closed)

Created:
9 years ago by asargent_no_longer_on_chrome
Modified:
9 years ago
CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move app notification getChannel API out of experimental We're still gating things at the server with trusted testers, but to be able to do experiments with real apps we need to remove the requirement for the experimental flag (you can't install apps from the webstore that have the experimental permission). BUG=98145 TEST=Should be able to install an app with the 'appNotifications' permission. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112648

Patch Set 1 #

Patch Set 2 : resolved conflicts with crrev.com/112548 #

Patch Set 3 : fix unit tests #

Patch Set 4 : another unit test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M chrome/browser/extensions/app_notification_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/app.js View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/app_notifications/launch.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/app_notifications/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
asargent_no_longer_on_chrome
9 years ago (2011-12-01 22:36:28 UTC) #1
Mihai Parparita -not on Chrome
LGTM, though I thought the web store had a way of whitelisting IDs that could ...
9 years ago (2011-12-01 23:56:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8776022/1
9 years ago (2011-12-02 01:12:11 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/common/extensions/extension_permission_set.cc. While running patch -p1 --forward --force; patching file chrome/common/extensions/extension_permission_set.cc ...
9 years ago (2011-12-02 01:12:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8776022/3011
9 years ago (2011-12-02 04:11:26 UTC) #5
commit-bot: I haz the power
Try job failure for 8776022-3011 (retry) on linux_rel for step "unit_tests". It's a second try, ...
9 years ago (2011-12-02 04:59:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8776022/4001
9 years ago (2011-12-02 05:00:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8776022/6002
9 years ago (2011-12-02 05:08:29 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-02 07:27:18 UTC) #9
Change committed as 112648

Powered by Google App Engine
This is Rietveld 408576698