Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 8776012: Remove all 192 static initializers from transport_security_state.cc (Closed)

Created:
9 years ago by Nico
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove all 192 static initializers from transport_security_state.cc This is necessary for gcc 4.4.3, see the comments on http://codereview.chromium.org/8687014 BUG=94925 TEST=none TBR=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112537

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M net/base/transport_security_state.cc View 1 4 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
9 years ago (2011-12-01 19:39:53 UTC) #1
agl
lgtm It's unfortunate that we have to do this for the sake of a compiler ...
9 years ago (2011-12-01 19:42:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8776012/1
9 years ago (2011-12-01 19:43:43 UTC) #3
commit-bot: I haz the power
Presubmit check for 8776012-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-01 19:43:45 UTC) #4
Nico
willchan: net owners stamp
9 years ago (2011-12-01 19:44:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8776012/1
9 years ago (2011-12-01 19:45:00 UTC) #6
commit-bot: I haz the power
Try job failure for 8776012-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=3102 Step "update" is always ...
9 years ago (2011-12-01 19:49:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8776012/3003
9 years ago (2011-12-01 19:51:43 UTC) #8
willchan no longer on Chromium
LGTM On Thu, Dec 1, 2011 at 11:51 AM, <commit-bot@chromium.org> wrote: > CQ is trying ...
9 years ago (2011-12-01 20:23:07 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-01 21:24:50 UTC) #10
Change committed as 112537

Powered by Google App Engine
This is Rietveld 408576698