Remove a few static initializers.

Remove a few static initializers.

The #defines are necessary for gcc 4.4.3 to not emit static initializers.

BUG=94925
TEST=none
TBR=bauerb

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111839

[commit-bot: I haz the power, 2011-11-29 00:22:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8687014/2001

[Bernhard Bauer, 2011-11-29 00:29:21]

http://codereview.chromium.org/8687014/diff/2001/webkit/plugins/npapi/plugin_...
File webkit/plugins/npapi/plugin_list.cc (right):

http://codereview.chromium.org/8687014/diff/2001/webkit/plugins/npapi/plugin_...
webkit/plugins/npapi/plugin_list.cc:78: #define kFlashDefinition { \
Does this mean that arrays are okay, but POD structs aren't?

[Nico, 2011-11-29 00:31:39]

http://codereview.chromium.org/8687014/diff/2001/webkit/plugins/npapi/plugin_...
File webkit/plugins/npapi/plugin_list.cc (right):

http://codereview.chromium.org/8687014/diff/2001/webkit/plugins/npapi/plugin_...
webkit/plugins/npapi/plugin_list.cc:78: #define kFlashDefinition { \
On 2011/11/29 00:29:21, Bernhard Bauer wrote:
> Does this mean that arrays are okay, but POD structs aren't?

It's still a POD struct, it's just that the array below that references this
isn't initialized through a const global but through an initializer list. Here's
a small repro case:

This produces a static initializer:

struct PluginGroupDefinition {
  const char* const identifier;
};
const PluginGroupDefinition kFlashDefinition = { "adobe-flash-player"};
static const PluginGroupDefinition kGroupDefinitions[] = {
  kFlashDefinition
};


This doesn't:

struct PluginGroupDefinition {
  const char* const identifier;
};
#define kFlashDefinition { "adobe-flash-player"}
static const PluginGroupDefinition kGroupDefinitions[] = {
  kFlashDefinition
};

(Only the kFlashDefinition definition line is different. That's with gcc 4.4.3;
clang gets it right either way.)

[commit-bot: I haz the power, 2011-11-29 02:27:12]

Change committed as 111839