Issue 8775064: Make PerTabPrefsTabHelper into PrefsTabHelper, move all prefs code into it.

Issue 8775064: Make PerTabPrefsTabHelper into PrefsTabHelper, move all prefs code into it. (Closed)

Created:
9 years ago by Avi (use Gerrit)

Modified:
9 years ago

Reviewers:
mnaganov (inactive), Jói

CC:
chromium-reviews, Paweł Hajdan Jr., Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make PerTabPrefsTabHelper into PrefsTabHelper, move all prefs code into it. BUG=105872 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113424

Patch Set 3 : this one instead #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -960 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/prefs/prefs_tab_helper.h	View	1 2	1 chunk	+59 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/prefs/prefs_tab_helper.cc	View	1	6 chunks	+57 lines, -349 lines	0 comments	Download
A +	chrome/browser/ui/prefs/prefs_tab_helper_unittest.cc	View	1	4 chunks	+25 lines, -25 lines	0 comments	Download
D	chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper.cc	View		1 chunk	+0 lines, -57 lines	0 comments	Download
D	chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper_unittest.cc	View		1 chunk	+0 lines, -103 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View		6 chunks	+5 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View		10 chunks	+12 lines, -357 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

mnaganov: This is your helper; should look good joi: Keeping you informed even when I'm ...

9 years ago (2011-12-02 19:41:39 UTC) #1

mnaganov (inactive)

On 2011/12/02 19:41:39, Avi wrote: > mnaganov: This is your helper; should look good > ...

9 years ago (2011-12-02 20:01:25 UTC) #2

mnaganov (inactive)

http://codereview.chromium.org/8775064/diff/1/chrome/browser/ui/prefs/prefs_tab_helper.cc File chrome/browser/ui/prefs/prefs_tab_helper.cc (right): http://codereview.chromium.org/8775064/diff/1/chrome/browser/ui/prefs/prefs_tab_helper.cc#newcode244 chrome/browser/ui/prefs/prefs_tab_helper.cc:244: tab_contents()->GetMutableRendererPrefs(), wrapper->profile()); nit: Should use wrapper_ http://codereview.chromium.org/8775064/diff/1/chrome/browser/ui/prefs/prefs_tab_helper.h File chrome/browser/ui/prefs/prefs_tab_helper.h ...

9 years ago (2011-12-02 20:01:32 UTC) #3

Jói

LGTM http://codereview.chromium.org/8775064/diff/1/chrome/browser/ui/prefs/prefs_tab_helper.h File chrome/browser/ui/prefs/prefs_tab_helper.h (right): http://codereview.chromium.org/8775064/diff/1/chrome/browser/ui/prefs/prefs_tab_helper.h#newcode30 chrome/browser/ui/prefs/prefs_tab_helper.h:30: protected: These can be private, unless you plan ...

9 years ago (2011-12-05 10:25:02 UTC) #4

mnaganov (inactive)

9 years ago (2011-12-07 09:56:47 UTC) #6

On 2011/12/06 23:23:26, Avi wrote:
> Mikhail, ptal; you should like it.

LGTM!

Expand Messages | Collapse Messages