Make PerTabPrefsTabHelper into PrefsTabHelper, move all prefs code into it.

chrome/browser/ui/prefs/prefs_tab_helper_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 #include "chrome/browser/prefs/pref_service.h"
-#include "chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper.h"
+#include "chrome/browser/ui/prefs/prefs_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/browser/ui/tab_contents/test_tab_contents_wrapper.h"
 #include "content/browser/tab_contents/test_tab_contents.h"
 #include "content/test/test_browser_thread.h"
 
 using content::BrowserThread;
 
-class TestPerTabPrefsTabHelper : public PerTabPrefsTabHelper {
+class TestPrefsTabHelper : public PrefsTabHelper {
  public:
-  explicit TestPerTabPrefsTabHelper(TabContentsWrapper* tab_contents)
-      : PerTabPrefsTabHelper(tab_contents),
-        was_override_web_prefernces_called_(false) {
+  explicit TestPrefsTabHelper(TabContentsWrapper* tab_contents)
+      : PrefsTabHelper(tab_contents),
+        was_override_web_preferences_called_(false) {
   }
-  virtual ~TestPerTabPrefsTabHelper() { }
+  virtual ~TestPrefsTabHelper() { }
 
   virtual void OverrideWebPreferences(WebPreferences* prefs) OVERRIDE {

[mnaganov (inactive), 2011/12/02 20:01:32]

I was overriding this method because I couldn't hook onto UpdateWebPreferences.
But since it has been moved into the Helper, it's now possible to verify that
UpdateWebPreferences was called on RenderViewCreated.

-    was_override_web_prefernces_called_ = true;
-    PerTabPrefsTabHelper::OverrideWebPreferences(prefs);
+    was_override_web_preferences_called_ = true;
+    PrefsTabHelper::OverrideWebPreferences(prefs);
   }
 
   void NotifyRenderViewCreated() {
     RenderViewCreated(NULL);
   }
 
-  bool was_override_web_prefernces_called() {
-    return was_override_web_prefernces_called_;
+  bool was_override_web_preferences_called() {
+    return was_override_web_preferences_called_;
   }
 
  private:
-  bool was_override_web_prefernces_called_;
+  bool was_override_web_preferences_called_;
 };
 
-class PerTabPrefsTabHelperTest : public TabContentsWrapperTestHarness {
+class PrefsTabHelperTest : public TabContentsWrapperTestHarness {
  public:
-  PerTabPrefsTabHelperTest()
+  PrefsTabHelperTest()
       : TabContentsWrapperTestHarness(),
         ui_thread_(BrowserThread::UI, &message_loop_) {}
 
-  virtual ~PerTabPrefsTabHelperTest() {}
+  virtual ~PrefsTabHelperTest() {}
 
   TabContentsWrapper* contents_wrapper2() {
     return contents_wrapper2_.get();
   }
 
   void SetContents2(TestTabContents* contents) {
     contents_wrapper2_.reset(
         contents ? new TabContentsWrapper(contents) : NULL);
   }
 
  protected:
   virtual void SetUp() OVERRIDE {
     TabContentsWrapperTestHarness::SetUp();
     SetContents2(CreateTestTabContents());
   }
 
   virtual void TearDown() OVERRIDE {
     contents_wrapper2_.reset();
     TabContentsWrapperTestHarness::TearDown();
   }
 
  private:
   content::TestBrowserThread ui_thread_;
   scoped_ptr<TabContentsWrapper> contents_wrapper2_;
 
-  DISALLOW_COPY_AND_ASSIGN(PerTabPrefsTabHelperTest);
+  DISALLOW_COPY_AND_ASSIGN(PrefsTabHelperTest);
 };
 
-TEST_F(PerTabPrefsTabHelperTest, PerTabJavaScriptEnabled) {
+TEST_F(PrefsTabHelperTest, PerTabJavaScriptEnabled) {
   const char* key = prefs::kWebKitJavascriptEnabled;
-  PrefService* prefs1 = contents_wrapper()->per_tab_prefs_tab_helper()->prefs();
+  PrefService* prefs1 = contents_wrapper()->prefs_tab_helper()->per_tab_prefs();
   PrefService* prefs2 =
-      contents_wrapper2()->per_tab_prefs_tab_helper()->prefs();
+      contents_wrapper2()->prefs_tab_helper()->per_tab_prefs();
   const bool initial_value = prefs1->GetBoolean(key);
   EXPECT_EQ(initial_value, prefs2->GetBoolean(key));
 
   prefs1->SetBoolean(key, !initial_value);
   EXPECT_EQ(!initial_value, prefs1->GetBoolean(key));
   EXPECT_EQ(initial_value, prefs2->GetBoolean(key));
 
   prefs1->SetBoolean(key, initial_value);
   EXPECT_EQ(initial_value, prefs1->GetBoolean(key));
   EXPECT_EQ(initial_value, prefs2->GetBoolean(key));
 
   prefs2->SetBoolean(key, !initial_value);
   EXPECT_EQ(initial_value, prefs1->GetBoolean(key));
   EXPECT_EQ(!initial_value, prefs2->GetBoolean(key));
 }
 
-TEST_F(PerTabPrefsTabHelperTest, OverridePrefsOnViewCreation) {
-  TestPerTabPrefsTabHelper* test_prefs_helper = new TestPerTabPrefsTabHelper(
+TEST_F(PrefsTabHelperTest, OverridePrefsOnViewCreation) {
+  TestPrefsTabHelper* test_prefs_helper = new TestPrefsTabHelper(
       contents_wrapper());
-  contents_wrapper()->per_tab_prefs_tab_helper_.reset(test_prefs_helper);
-  EXPECT_FALSE(test_prefs_helper->was_override_web_prefernces_called());
+  contents_wrapper()->prefs_tab_helper_.reset(test_prefs_helper);
+  EXPECT_FALSE(test_prefs_helper->was_override_web_preferences_called());
   test_prefs_helper->NotifyRenderViewCreated();
-  EXPECT_TRUE(test_prefs_helper->was_override_web_prefernces_called());
+  EXPECT_TRUE(test_prefs_helper->was_override_web_preferences_called());
 }