net/http/http_network_transaction.cc - Issue 8775044: Resend requests when we only learn a connection has closed while

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 8775044: Resend requests when we only learn a connection has closed while (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Cleanup comments Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_transaction.cc

===================================================================

--- net/http/http_network_transaction.cc (revision 112237)

+++ net/http/http_network_transaction.cc (working copy)

@@ -1187,6 +1187,11 @@

case ERR_CONNECTION_RESET:

case ERR_CONNECTION_CLOSED:

case ERR_CONNECTION_ABORTED:

+ // Under certain circumstances, we may first learn a socket's been

willchan no longer on Chromium 2011/12/07 18:46:28 Can you describe the circumstance? Explain that th

mmenke 2011/12/07 19:34:11 Done. Added a link to the bug, too, as it now con

+ // disconnected when trying to read/write from it or get its IP address,

willchan no longer on Chromium 2011/12/07 18:46:28 getting the peer's IP address

mmenke 2011/12/07 19:34:11 Completely rewrote the sentence.

+ // before processing the connection closed/reset message. In this case,

+ // we'll receive the following error code.

+ case ERR_SOCKET_NOT_CONNECTED:

if (ShouldResendRequest(error)) {

net_log_.AddEvent(

NetLog::TYPE_HTTP_TRANSACTION_RESTART_AFTER_ERROR,

« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »