Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 8775024: Fix NTP not to slide with mouse (Closed)

Created:
9 years ago by Rick Byers
Modified:
9 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, dhollowa+watch_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org, estade+watch_chromium.org, Dan Beam
Visibility:
Public.

Description

Fix NTP not to slide with mouse Fix TouchHandler to only respond to mouse events when explicitly requested. By default it should respond only to touch events. As additional insurance (to return the runtime behavior to exactly how it was before my change since we're about to branch for M17), don't enable the use of TouchHandler unless we're running with --touch-optimized-ui. Also clean up a few touch NTP related things: - Remove unused copy of ToucHandler (probably legacy from previous login work) and reference to Grabber (which already doesn't exist in the tree). - Remove stale ntp4 script for running closure/lint. BUG=106012 TEST=Manual - try dragging ntp page with the mouse, shouldn't move Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112568

Patch Set 1 #

Patch Set 2 : Don't include tweak to enable Xinput2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -969 lines) Patch
M chrome/browser/resources/ntp4/page_list_view.js View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/resources/ntp4/tools/check.sh View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/resources/ntp4/tools/externs.js View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/card_slider.js View 1 chunk +16 lines, -15 lines 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/touch_handler.js View 2 chunks +8 lines, -4 lines 0 comments Download
D chrome/browser/resources/touchhandler.js View 1 chunk +0 lines, -851 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Byers
Hey Evan, Can you review this small NTP change please? Thanks, Rick
9 years ago (2011-12-01 20:21:31 UTC) #1
Evan Stade
lgtm
9 years ago (2011-12-01 21:46:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/8775024/2001
9 years ago (2011-12-01 21:49:22 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-01 23:09:58 UTC) #4
Change committed as 112568

Powered by Google App Engine
This is Rietveld 408576698