Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2072)

Unified Diff: chrome/browser/resources/ntp4/tools/check.sh

Issue 8775024: Fix NTP not to slide with mouse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't include tweak to enable Xinput2 Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp4/page_list_view.js ('k') | chrome/browser/resources/ntp4/tools/externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/tools/check.sh
diff --git a/chrome/browser/resources/ntp4/tools/check.sh b/chrome/browser/resources/ntp4/tools/check.sh
deleted file mode 100755
index 8f4ab7d628384d61a7d837647c192dc1cee6ac8b..0000000000000000000000000000000000000000
--- a/chrome/browser/resources/ntp4/tools/check.sh
+++ /dev/null
@@ -1,57 +0,0 @@
-#!/bin/bash
-
-# Copyright (c) 2011 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-# This script checks the touch_ntp code for common errors and style
-# problems using the closure compiler (jscompiler) and closure linter
-# (gjslint) - both of which must be on the path.
-# See http://code.google.com/closure/compiler/ and
-# http://code.google.com/closure/utilities/ for details on these tools.
-
-SOURCES="event_tracker.js touch_handler.js card_slider.js new_tab.js grabber.js apps_page.js recently_closed.js"
-
-# First run the closure compiler looking for syntactic issues.
-# Note that we throw away the output from jscompiler since it's use
-# is not yet common in Chromium and for now we want it to be an optional
-# tool for helping to find bugs, not something that actually changes
-# the embedded JavaScript (making it harder to debug, for example).
-
-# I used to run with '--warning_level VERBOSE' to get full type checking
-# but there are enough limitations in the language and compiler that
-# it doesn't seem worth the benefit (spent more time trying to apease
-# the compiler and reviewers of my code than the compiler saved me).
-
-# Enable support for property get/set syntax as added in ecmascript5.
-# Note that this requires a build of JSCompiler that is newer than
-# Feb 2011.
-CARGS="--language_in=ECMASCRIPT5_STRICT"
-
-CARGS+=" --js_output_file /dev/null"
-for S in $SOURCES tools/externs.js; do
- CARGS+=" --js $S"
-done
-
-cd `dirname $0`/..
-
-echo jscompiler $CARGS
-jscompiler $CARGS || exit 1
-
-# Now run the closure linter looking for style issues.
-
-# GJSLint can't follow the more concice syntax for prototype members and
-# complains about missing @this annotations (filed as bug 4073735). To
-# cope for now I just just off all missing-JSDoc warnings.
-LARGS="--nojsdoc"
-
-# Verify extra rules like spacing and indentation
-LARGS+=" --strict"
-
-# Might as well check the bit of JS we have embedded in HTML too
-LARGS+=" --check_html new_tab.html"
-
-LARGS+=" $SOURCES"
-
-echo gjslint $LARGS
-gjslint $LARGS || exit 1
« no previous file with comments | « chrome/browser/resources/ntp4/page_list_view.js ('k') | chrome/browser/resources/ntp4/tools/externs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698