Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 8774041: Upgrade all call sites of PageNavigator::OpenURL that pass a referrer to use OpenURLParams (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/applescript/tab_applescript.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index b9fba7064782c46f9bdb745ab755ec6455d2fc4f..284ea262ceb60729a025007b63b7a9ee33e3a504 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -573,6 +573,8 @@ TabContents* TabContents::OpenURL(const GURL& url,
const GURL& referrer,
WindowOpenDisposition disposition,
content::PageTransition transition) {
+ // For specifying a referrer, use the version of OpenURL taking OpenURLParams.
+ DCHECK(referrer.is_empty());
return OpenURL(OpenURLParams(url, referrer, disposition, transition,
false));
}
« no previous file with comments | « chrome/browser/ui/cocoa/applescript/tab_applescript.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698