Upgrade all call sites of PageNavigator::OpenURL that pass a referrer to use OpenURLParams

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 555 matching lines @@
   return notify_disconnection() &&
       !showing_interstitial_page() &&
       !render_view_host()->SuddenTerminationAllowed();
 }
 
 // TODO(adriansc): Remove this method once refactoring changed all call sites.
 TabContents* TabContents::OpenURL(const GURL& url,
                                   const GURL& referrer,
                                   WindowOpenDisposition disposition,
                                   content::PageTransition transition) {
+  // For specifying a referrer, use the version of OpenURL taking OpenURLParams.
+  DCHECK(referrer.is_empty());
   return OpenURL(OpenURLParams(url, referrer, disposition, transition,
                                false));
 }
 
 TabContents* TabContents::OpenURL(const OpenURLParams& params) {
   if (delegate_) {
     TabContents* new_contents = delegate_->OpenURLFromTab(this, params);
     // Notify observers.
     FOR_EACH_OBSERVER(TabContentsObserver, observers_,
                       DidOpenURL(params.url, params.referrer,
@@ skipping 1470 matching lines @@
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   // Can be NULL during tests.
   if (rwh_view)
     rwh_view->SetSize(view()->GetContainerSize());
 }
 
 bool TabContents::GotResponseToLockMouseRequest(bool allowed) {
   return render_view_host() ?
       render_view_host()->GotResponseToLockMouseRequest(allowed) : false;
 }