Issue 8774041: Upgrade all call sites of PageNavigator::OpenURL that pass a referrer to use OpenURLParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8774041: Upgrade all call sites of PageNavigator::OpenURL that pass a referrer to use OpenURLParams (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)

Modified:
9 years ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upgrade all call sites of PageNavigator::OpenURL that pass a referrer to use OpenURLParams BUG=105028 TEST=no functional change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112703

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
M	chrome/browser/plugin_observer.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/insecure_content_infobar_delegate.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/tab_applescript.mm	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

plz review In a follow-up change, I will replace the referrer URL with a referrer ...

9 years ago (2011-12-02 10:03:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8774041/3001

9 years ago (2011-12-02 14:28:02 UTC) #3

Change committed as 112703

Expand Messages | Collapse Messages