Issue 8774022: Converting BubbleWindow uses, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8774022: Converting BubbleWindow uses, etc. (Closed)

Created:
9 years ago by msw

Modified:
9 years ago

Reviewers:

CC:
chromium-reviews, msw+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, alicet1, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, bshe, Emmanuel Saint-loubert-Bié

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update ExtensionDialog; deprecate BubbleWindow. ExtensionDialog: Rebase this on the new views bubble. Fix SelectFileDialogExtension (save and open dialogs) bubble interaction. Remove ExtensionDialogObserver complexity. BubbleWindow: Nix this NativeWidgetGtk specialization; use ShowHtmlDialog. Redirects WidgetDelegate users to the compatible CreateViewsWindow. BUG=98322 TEST=BubbleWindow and ExtensionDialog users work as before. CLOSING THIS ISSUE (SUPERSEDED BY codereview.chromium.org/8800032)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -617 lines)			Patch
M	chrome/browser/chromeos/choose_mobile_network_dialog.cc	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
D	chrome/browser/chromeos/frame/bubble_frame_view.h	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/browser/chromeos/frame/bubble_frame_view.cc	View	1 2 3 4	1 chunk	+0 lines, -245 lines	0 comments	Download
D	chrome/browser/chromeos/frame/bubble_window.h	View		1 chunk	+0 lines, -70 lines	0 comments	Download
D	chrome/browser/chromeos/frame/bubble_window_gtk.cc	View		1 chunk	+0 lines, -64 lines	0 comments	Download
D	chrome/browser/chromeos/frame/bubble_window_style.h	View		1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/browser/chromeos/frame/bubble_window_style.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/login/help_app_launcher.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_html_dialog.h	View	1	4 chunks	+2 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_html_dialog.cc	View	1	5 chunks	+6 lines, -50 lines	0 comments	Download
M	chrome/browser/chromeos/login/proxy_settings_dialog.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/native_dialog_window.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/sim_dialog_delegate.cc	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/dialog_style.h	View	1 2 3 4	1 chunk	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/views/keyboard_overlay_dialog_view.cc	View	1	2 chunks	+2 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/window.cc	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5	1 chunk	+0 lines, -6 lines	0 comments	Download

Issue 8774022: Converting BubbleWindow uses, etc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Cleanup and sync. #

Patch Set 3 : Remove ExtensionDialogObserver complexity; fix SelectFileDialogExtension bubble interaction. #

Patch Set 4 : Fix Mac build; limit ExtensionDialog to views. #

Patch Set 5 : Sync and merge. #

Patch Set 6 : Doesn't build... just a checkpoint for this work, might change approach. #