chrome/browser/chromeos/login/proxy_settings_dialog.cc - Issue 8774022: Converting BubbleWindow uses, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/proxy_settings_dialog.cc

Issue 8774022: Converting BubbleWindow uses, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Doesn't build... just a checkpoint for this work, might change approach. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/proxy_settings_dialog.cc

diff --git a/chrome/browser/chromeos/login/proxy_settings_dialog.cc b/chrome/browser/chromeos/login/proxy_settings_dialog.cc

index 2a5a799638ed90c67b1b05268e902f39a2a6af21..5788096baefccb564bcf5522bf1b3f5631d5a92f 100644

--- a/chrome/browser/chromeos/login/proxy_settings_dialog.cc

+++ b/chrome/browser/chromeos/login/proxy_settings_dialog.cc

@@ -35,8 +35,7 @@ ProxySettingsDialog::ProxySettingsDialog(LoginHtmlDialog::Delegate* delegate,

delegate,

window,

std::wstring(),

- GURL(chrome::kChromeUIProxySettingsURL),

- LoginHtmlDialog::STYLE_BUBBLE) {

+ GURL(chrome::kChromeUIProxySettingsURL)) {

gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size()));

SetDialogSize(CalculateSize(screen_bounds.width(),

kProxySettingsDialogReasonableWidth,