remoting/protocol/session_manager.h - Issue 8774017: Add AUTHENTICATED session state.

Unified Diff: remoting/protocol/session_manager.h

Issue 8774017: Add AUTHENTICATED session state. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: - Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: remoting/protocol/session_manager.h

diff --git a/remoting/protocol/session_manager.h b/remoting/protocol/session_manager.h

index 7a02c3da74645ebbb64a9e5e313ec312c5ebe0b7..c222e45438ccbe961a3200279d2364ca637860a9 100644

--- a/remoting/protocol/session_manager.h

+++ b/remoting/protocol/session_manager.h

@@ -18,12 +18,20 @@

// The callback function decides whether the session should be accepted or

// rejected.

+// AUTHENTICATION

+// Implementations of Session and SessionManager interfaces delegate

Wez 2011/12/03 00:10:37 nit: ... of the Session ...

Sergey Ulanov 2011/12/06 02:33:20 Done.

+// authentication to the Authenticator interface. When accepting

Wez 2011/12/03 00:10:37 nit: ... to an Authenticator implementation ... ?

Sergey Ulanov 2011/12/06 02:33:20 Done.

+// incoming connection authenticators are created using authenticator

Wez 2011/12/03 00:10:37 nit: For incoming connections ... ... created usin

Sergey Ulanov 2011/12/06 02:33:20 Done.

+// factory set via set_authenticator_factory() method. For outgoing

Wez 2011/12/03 00:10:37 nit: ... via the set_authenticator_factory() metho

Sergey Ulanov 2011/12/06 02:33:20 Done.

+// sessions authenticator must be passed to Connect() method. Session

Wez 2011/12/03 00:10:37 nit: ... sessions the authenticator must be passed

Wez 2011/12/03 00:10:37 nit: The Session's state changes to AUTHENTICATED

Sergey Ulanov 2011/12/06 02:33:20 Done.

+// state is changed from CONNECTED to AUTHENTICATED once

+// authentication is finished

+//

// SESSION OWNERSHIP AND SHUTDOWN

-// SessionManager owns all Sessions it creates. The manager must not

-// be closed or destroyed before all sessions created by that

-// SessionManager are destroyed. Caller owns Sessions created by a

-// SessionManager (except rejected sessions). Sessions must outlive

-// SessionManager, and SignalStrategy must outlive SessionManager.

+// The manager must not be closed or destroyed before all sessions

Wez 2011/12/03 00:10:37 Which manager? The SessionManager?

Sergey Ulanov 2011/12/06 02:33:20 Done.

+// created by that SessionManager are destroyed. Caller owns Sessions

+// created by a SessionManager (except rejected

+// sessions). SignalStrategy must outlive SessionManager.

Wez 2011/12/03 00:10:37 nit: Missing "the"s

Sergey Ulanov 2011/12/06 02:33:20 Done.

// PROTOCOL VERSION NEGOTIATION

// When client connects to a host it sends a session-initiate stanza with list

« remoting/protocol/session.h ('K') | « remoting/protocol/session.h ('k') | no next file » | no next file with comments »