Add AUTHENTICATED session state.

remoting/protocol/session_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The purpose of SessionManager is to facilitate creation of chromotocol
 // sessions. Both host and client use it to establish chromotocol
 // sessions. JingleChromotocolServer implements this inteface using
 // libjingle.
 //
 // OUTGOING SESSIONS
 // Connect() must be used to create new session to a remote host. The
 // returned session is initially in INITIALIZING state. Later state is
 // changed to CONNECTED if the session is accepted by the host or
 // CLOSED if the session is rejected.
 //
 // INCOMING SESSIONS
 // The IncomingSessionCallback is called when a client attempts to connect.
 // The callback function decides whether the session should be accepted or
 // rejected.
 //
+// AUTHENTICATION
+// Implementations of Session and SessionManager interfaces delegate

[Wez, 2011/12/03 00:10:37]

nit: ... of the Session ... 

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

+// authentication to the Authenticator interface. When accepting

[Wez, 2011/12/03 00:10:37]

nit: ... to an Authenticator implementation ... ?

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

+// incoming connection authenticators are created using authenticator

[Wez, 2011/12/03 00:10:37]

nit: For incoming connections ...
... created using an AuthenticatorFactory ...

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

+// factory set via set_authenticator_factory() method. For outgoing

[Wez, 2011/12/03 00:10:37]

nit: ... via the set_authenticator_factory() method ...

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

+// sessions authenticator must be passed to Connect() method. Session

[Wez, 2011/12/03 00:10:37]

nit: ... sessions the authenticator must be passed to the Connect() method.

[Wez, 2011/12/03 00:10:37]

nit: The Session's state changes to AUTHENTICATED once authentication succeeds.

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

+// state is changed from CONNECTED to AUTHENTICATED once
+// authentication is finished
+//
 // SESSION OWNERSHIP AND SHUTDOWN
-// SessionManager owns all Sessions it creates. The manager must not
-// be closed or destroyed before all sessions created by that
-// SessionManager are destroyed. Caller owns Sessions created by a
-// SessionManager (except rejected sessions). Sessions must outlive
-// SessionManager, and SignalStrategy must outlive SessionManager.
+// The manager must not be closed or destroyed before all sessions

[Wez, 2011/12/03 00:10:37]

Which manager? The SessionManager?

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

+// created by that SessionManager are destroyed. Caller owns Sessions
+// created by a SessionManager (except rejected
+// sessions). SignalStrategy must outlive SessionManager.

[Wez, 2011/12/03 00:10:37]

nit: Missing "the"s

[Sergey Ulanov, 2011/12/06 02:33:20]

Done.

 //
 // PROTOCOL VERSION NEGOTIATION
 // When client connects to a host it sends a session-initiate stanza with list
 // of supported configurations for each channel. If the host decides to accept
 // session, then it selects configuration that is supported by both sides
 // and then replies with the session-accept stanza that contans selected
 // configuration. The configuration specified in the session-accept is used
 // for the session.
 //
 // The CandidateSessionConfig class represents list of configurations
@@ skipping 106 matching lines @@
       AuthenticatorFactory* authenticator_factory) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SessionManager);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_SESSION_MANAGER_H_