Issue 8774004: Fixed ChromeOS clang build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8774004: Fixed ChromeOS clang build. (Closed)

Created:
9 years ago by Joao da Silva

Modified:
9 years ago

Reviewers:
alicet1, Simon Que

CC:
chromium-reviews, robertshield, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixed ChromeOS clang build. LockScreen and UnlockScreen became overloaded names in TestingAutomationProvider after http://codereview.chromium.org/8664014 Missing virtual after adding OVERRIDE in http://codereview.chromium.org/8761010 TBR=sque@chromium.org, alicet@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112461

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
M	chrome/browser/automation/testing_automation_provider.h	View	2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View	2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/crypto_module_password_dialog_view.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm

thanks for fixing it!