Issue 8761010: fix broken linux_clang_chromeos_dbg build due to style violation.

Issue 8761010: fix broken linux_clang_chromeos_dbg build due to style violation. (Closed)

Created:
9 years ago by alicet1

Modified:
9 years ago

Reviewers:
Nikita (slow), sky

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

fix style violation for clang style plugin on chromeos. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112380

Patch Set 2 : update #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
	M	chrome/browser/ui/views/crypto_module_password_dialog_view.h	View	1	1 chunk	+10 lines, -10 lines	1 comment	Download
	M	chrome/browser/ui/views/crypto_module_password_dialog_view.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alicet@chromium.org/8761010/2001

9 years ago (2011-12-01 01:11:16 UTC) #3

Nikita (slow)

http://codereview.chromium.org/8761010/diff/2001/chrome/browser/ui/views/crypto_module_password_dialog_view.h File chrome/browser/ui/views/crypto_module_password_dialog_view.h (right): http://codereview.chromium.org/8761010/diff/2001/chrome/browser/ui/views/crypto_module_password_dialog_view.h#newcode42 chrome/browser/ui/views/crypto_module_password_dialog_view.h:42: string16 GetDialogButtonLabel( Missing virtual here. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20Clang%20%28ChromeOS%20dbg%29/builds/3767/steps/compile/logs/stdio

9 years ago (2011-12-01 15:48:01 UTC) #5

alicet1

9 years ago (2011-12-01 15:59:21 UTC) #6

On 2011/12/01 15:48:01, Nikita Kostylev wrote:
>
http://codereview.chromium.org/8761010/diff/2001/chrome/browser/ui/views/cryp...
> File chrome/browser/ui/views/crypto_module_password_dialog_view.h (right):
> 
>
http://codereview.chromium.org/8761010/diff/2001/chrome/browser/ui/views/cryp...
> chrome/browser/ui/views/crypto_module_password_dialog_view.h:42: string16
> GetDialogButtonLabel(
> Missing virtual here.
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%2520Clang%2520...

yes, joaodasilva fixed it at 
http://codereview.chromium.org/8774004

thanx,
alice

Expand Messages | Collapse Messages