Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8773039: Clean up multi byte nop support on x64 to more closely match IA32. (Closed)

Created:
9 years ago by Erik Corry
Modified:
9 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Clean up multi byte nop support on x64 to more closely match IA32. Fix missing instruction in disassembler. Fix wrong disassembly of multi-byte NOP on x64 Add test of disassembler on 64 bit! Committed: http://code.google.com/p/v8/source/detail?r=10147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, -91 lines) Patch
M src/x64/assembler-x64.h View 3 chunks +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 4 chunks +68 lines, -74 lines 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/disasm-x64.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/SConscript View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 4 chunks +81 lines, -0 lines 0 comments Download
A test/cctest/test-disasm-x64.cc View 1 chunk +429 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years ago (2011-12-02 14:12:52 UTC) #1
Michael Starzinger
9 years ago (2011-12-02 16:19:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698