Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8773025: GTK: More removal of raw GtkWidget->allocation access. (Closed)

Created:
9 years ago by Elliot Glaysher
Modified:
9 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., kkania, mihaip+watch_chromium.org, Aaron Boodman, robertshield, brettw-cc_chromium.org, ajwong+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: More removal of raw GtkWidget->allocation access. BUG=79722 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -63 lines) Patch
M chrome/browser/automation/testing_automation_provider_gtk.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 5 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_link_button.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_custom_menu_item.cc View 3 chunks +21 lines, -11 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_input_event_box.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/nine_box.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.cc View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Elliot Glaysher
Another allocation patch.
9 years ago (2011-12-02 00:29:00 UTC) #1
Elliot Glaysher
ping
9 years ago (2011-12-02 20:16:50 UTC) #2
Evan Stade
rubber stamp lgtm
9 years ago (2011-12-02 20:45:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8773025/1
9 years ago (2011-12-02 20:48:20 UTC) #4
commit-bot: I haz the power
Try job failure for 8773025-1 (retry) (retry) (previous was lost) on win_rel for steps "browser_tests, ...
9 years ago (2011-12-03 01:39:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8773025/1
9 years ago (2011-12-05 02:09:47 UTC) #6
commit-bot: I haz the power
Try job failure for 8773025-1 (retry) on mac_rel for steps "browser_tests, ui_tests". It's a second ...
9 years ago (2011-12-05 05:10:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8773025/1
9 years ago (2011-12-05 18:49:11 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-05 21:31:11 UTC) #9 
Change committed as 113031

Powered by Google App Engine
This is Rietveld 408576698