GTK: More removal of raw GtkWidget->allocation access.

chrome/browser/ui/gtk/find_bar_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/find_bar_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 354 matching lines @@
   ignore_changed_signal_ = true;
   gtk_entry_set_text(GTK_ENTRY(text_entry_), find_text_utf8.c_str());
   ignore_changed_signal_ = false;
 }
 
 void FindBarGtk::UpdateUIForFindResult(const FindNotificationDetails& result,
                                        const string16& find_text) {
   if (!result.selection_rect().IsEmpty()) {
     selection_rect_ = result.selection_rect();
     int xposition = GetDialogPosition(result.selection_rect()).x();
-    if (xposition != widget()->allocation.x)
+    GtkAllocation allocation;
+    gtk_widget_get_allocation(widget(), &allocation);
+    if (xposition != allocation.x)
       Reposition();
   }
 
   // Once we find a match we no longer want to keep track of what had
   // focus. EndFindSession will then set the focus to the page content.
   if (result.number_of_matches() > 0)
     focus_store_.Store(NULL);
 
   std::string find_text_utf8 = UTF16ToUTF8(find_text);
   bool have_valid_range =
@@ skipping 421 matching lines @@
 // static
 gboolean FindBarGtk::OnContentEventBoxExpose(GtkWidget* widget,
                                              GdkEventExpose* event,
                                              FindBarGtk* bar) {
   if (bar->theme_service_->UsingNativeTheme()) {
     // Draw the text entry background around where we input stuff. Note the
     // decrement to |width|. We do this because some theme engines
     // (*cough*Clearlooks*cough*) don't do any blending and use thickness to
     // make sure that widgets never overlap.
     int padding = gtk_widget_get_style(widget)->xthickness;
-    GdkRectangle rec = {
-      widget->allocation.x,
-      widget->allocation.y,
-      widget->allocation.width - padding,
-      widget->allocation.height
-    };
+    GdkRectangle rec;
+    gtk_widget_get_allocation(widget, &rec);
+    rec.width -= padding;
 
     gtk_util::DrawTextEntryBackground(bar->text_entry_, widget,
                                       &event->area, &rec);
   }
 
   return FALSE;
 }
 
 // Used to handle custom painting of |container_|.
 gboolean FindBarGtk::OnExpose(GtkWidget* widget, GdkEventExpose* e,
                               FindBarGtk* bar) {
+  GtkAllocation allocation;
+  gtk_widget_get_allocation(widget, &allocation);
+
   if (bar->theme_service_->UsingNativeTheme()) {
-    if (bar->container_width_ != widget->allocation.width ||
-        bar->container_height_ != widget->allocation.height) {
+    if (bar->container_width_ != allocation.width ||
+        bar->container_height_ != allocation.height) {
       std::vector<GdkPoint> mask_points = MakeFramePolygonPoints(
-          widget->allocation.width, widget->allocation.height, FRAME_MASK);
+          allocation.width, allocation.height, FRAME_MASK);
       GdkRegion* mask_region = gdk_region_polygon(&mask_points[0],
                                                   mask_points.size(),
                                                   GDK_EVEN_ODD_RULE);
       // Reset the shape.
       gdk_window_shape_combine_region(widget->window, NULL, 0, 0);
       gdk_window_shape_combine_region(widget->window, mask_region, 0, 0);
       gdk_region_destroy(mask_region);
 
-      bar->container_width_ = widget->allocation.width;
-      bar->container_height_ = widget->allocation.height;
+      bar->container_width_ = allocation.width;
+      bar->container_height_ = allocation.height;
     }
 
     GdkDrawable* drawable = GDK_DRAWABLE(e->window);
     GdkGC* gc = gdk_gc_new(drawable);
     gdk_gc_set_clip_rectangle(gc, &e->area);
     GdkColor color = bar->theme_service_->GetBorderColor();
     gdk_gc_set_rgb_fg_color(gc, &color);
 
     // Stroke the frame border.
     std::vector<GdkPoint> points = MakeFramePolygonPoints(
-        widget->allocation.width, widget->allocation.height, FRAME_STROKE);
+        allocation.width, allocation.height, FRAME_STROKE);
     gdk_draw_lines(drawable, gc, &points[0], points.size());
 
     g_object_unref(gc);
   } else {
-    if (bar->container_width_ != widget->allocation.width ||
-        bar->container_height_ != widget->allocation.height) {
+    if (bar->container_width_ != allocation.width ||
+        bar->container_height_ != allocation.height) {
       // Reset the shape.
       gdk_window_shape_combine_region(widget->window, NULL, 0, 0);
       SetDialogShape(bar->container_);
 
-      bar->container_width_ = widget->allocation.width;
-      bar->container_height_ = widget->allocation.height;
+      bar->container_width_ = allocation.width;
+      bar->container_height_ = allocation.height;
     }
 
     cairo_t* cr = gdk_cairo_create(GDK_DRAWABLE(widget->window));
     gdk_cairo_rectangle(cr, &e->area);
     cairo_clip(cr);
 
     gfx::Point tabstrip_origin =
         bar->window_->tabstrip()->GetTabStripOriginForWidget(widget);
 
     gtk_util::DrawThemedToolbarBackground(widget, cr, e, tabstrip_origin,
@@ skipping 90 matching lines @@
   return FALSE;  // Continue propagation.
 }
 
 gboolean FindBarGtk::OnFocusOut(GtkWidget* entry, GdkEventFocus* event) {
   g_signal_handlers_disconnect_by_func(
       gdk_keymap_get_for_display(gtk_widget_get_display(entry)),
       reinterpret_cast<gpointer>(&OnKeymapDirectionChanged), this);
 
   return FALSE;  // Continue propagation.
 }