chromeos: Fix closing issues with WebUI form-repost dialog.

chromeos: Fix closing issues with WebUI form-repost dialog.

The WebUI form-repost warning dialog wasn't getting closed
when you reloaded the page or navigated away from it.
bauerb pointed out that this was because the dialog's
ConstrainedWindow wasn't getting registered in the
RepostFormWarningController.

This change also updates
RepostFormWarningTest.TestDoubleReload from ui_tests to
check that we don't open multiple dialogs and that we close
the dialog when navigating away.

BUG=105546
TEST=manual: checked that old dialogs are closed on reload and when hitting the back button


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112639

[Daniel Erat, 2011-12-01 23:44:49]

http://codereview.chromium.org/8771017/diff/1/chrome/browser/repost_form_warn...
File chrome/browser/repost_form_warning_uitest.cc (right):

http://codereview.chromium.org/8771017/diff/1/chrome/browser/repost_form_warn...
chrome/browser/repost_form_warning_uitest.cc:53:
ASSERT_TRUE(tab->GetConstrainedWindowCount(&num_constrained_windows));
Do you happen to know if it's safe to check this immediately after the
ReloadAsync() calls, or is there a risk that the dialog won't be shown yet?

[Bernhard Bauer, 2011-12-01 23:54:53]

LGTM, thanks!

http://codereview.chromium.org/8771017/diff/1/chrome/browser/repost_form_warn...
File chrome/browser/repost_form_warning_uitest.cc (right):

http://codereview.chromium.org/8771017/diff/1/chrome/browser/repost_form_warn...
chrome/browser/repost_form_warning_uitest.cc:53:
ASSERT_TRUE(tab->GetConstrainedWindowCount(&num_constrained_windows));
On 2011/12/01 23:44:49, Daniel Erat wrote:
> Do you happen to know if it's safe to check this immediately after the
> ReloadAsync() calls, or is there a risk that the dialog won't be shown yet?

No, it should appear immediately. The async in there just means that we don't
wait for the navigation to complete (as we will show the dialog instead of
navigating).

[commit-bot: I haz the power, 2011-12-02 01:38:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/8771017/1

[commit-bot: I haz the power, 2011-12-02 04:50:30]

Change committed as 112639