chromeos: Fix closing issues with WebUI form-repost dialog.

chrome/browser/repost_form_warning_uitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/net/url_fixer_upper.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/automation/automation_proxy.h"
@@ skipping 30 matching lines @@
   // Load a form.
   ASSERT_TRUE(tab->NavigateToURL(test_server.GetURL("files/form.html")));
   // Submit it.
   ASSERT_TRUE(tab->NavigateToURL(GURL(
       "javascript:document.getElementById('form').submit()")));
 
   // Try to reload it twice, checking for repost.
   tab->ReloadAsync();
   tab->ReloadAsync();
 
+  // There should only be one dialog open.
+  int num_constrained_windows = 0;
+  ASSERT_TRUE(tab->GetConstrainedWindowCount(&num_constrained_windows));

[Daniel Erat, 2011/12/01 23:44:49]

Do you happen to know if it's safe to check this immediately after the
ReloadAsync() calls, or is there a risk that the dialog won't be shown yet?

[Bernhard Bauer, 2011/12/01 23:54:53]

No, it should appear immediately. The async in there just means that we don't
wait for the navigation to complete (as we will show the dialog instead of
navigating).

+  EXPECT_EQ(1, num_constrained_windows);
+
   // Navigate away from the page (this is when the test usually crashes).
   ASSERT_TRUE(tab->NavigateToURL(test_server.GetURL("bar")));
+
+  // The dialog should've been closed.
+  ASSERT_TRUE(tab->GetConstrainedWindowCount(&num_constrained_windows));
+  EXPECT_EQ(0, num_constrained_windows);
 }
 
 #if defined(OS_WIN)
 // http://crbug.com/47228
 #define MAYBE_TestLoginAfterRepost FLAKY_TestLoginAfterRepost
 #else
 #define MAYBE_TestLoginAfterRepost TestLoginAfterRepost
 #endif
 
 TEST_F(RepostFormWarningTest, MAYBE_TestLoginAfterRepost) {
@@ skipping 18 matching lines @@
   // Navigate to a page that requires authentication, bringing up another
   // tab-modal sheet.
   ASSERT_TRUE(tab->NavigateToURL(test_server.GetURL("auth-basic")));
 
   // Try to reload it again.
   tab->ReloadAsync();
 
   // Navigate away from the page.
   ASSERT_TRUE(tab->NavigateToURL(test_server.GetURL("bar")));
 }